Closed DJAndries closed 8 months ago
@DJAndries @kylehickinson I am not sure which NTP SI metrics you are referring here, please do mention the metrics names in the issues.
I think the metrics implemented in this issue is Brave.NTP.SponsoredNewTabsCreated.2
as per the issues description. correct me if I am wrong. Thanks!
Verification INPROGRESS on Brave Nightly version 1.65.77
running iPhone 8 - iOS version 16.7.5
Verified the test plan from https://github.com/brave/brave-ios/pull/8676
Prerequisites: Open Settings
-> BraveCoreSwitches
-> Enable the switch Express Rotation Interval
, enter the 10
in the rotation interval text box and click on Save
Steps folllowed:
1.65.77
, follow prerequisites step mentioned aboveSetting
via app menuView Chromium Local State
fileBrave.NTP.SponsoredNewTabsCreated.2
View Brave Histogram (p3a) Logs
via settings app menuBrave.NTP.SponsoredNewTabsCreated.2
Local state | Histogram |
---|---|
@kylehickinson: The metrics Brave.NTP.SponsoredNewTabsCreated.2
is not shown on the Chromium Local State
file even after viewing 2 to 3 NTP Sponsored image tabs. But the metrics is shown under View Brave Histogram (p3a) Logs
. Is this expected? To verify the different response values mentioned via wiki (shown in image below) we need to show the values under local state file. Is there any other way to verify the different response values. Let me know your thoughts on this?
Hi @GeetaSarvadnya, this particular issue is not the bucket for Brave.NTP.SponsoredNewTabsCreated
, it's for the dynamic NTP-SI metrics, sorry for the confusion. You'd be looking to make sure those dynamic p3a metrics are being updated. Those are the ones that start with creativeInstanceId
@kylehickinson Verified the issue again. After viewing NTP SI, I am seeing creativeInstanceId
under "dynamic_metrics"
via local state file. But there is some difference between the desktop and iOS creativeInstanceId
metrics value.
In Desktop the metrics value is shown as "creativeInstanceId.d27f16ec-a9bf-4e77-aaa7-bd778ccf482e.views": 2
but in iOS the metrics value is "creativeInstanceId.total.count": 2
. Is this expected?
Desktop | iOS |
---|---|
@GeetaSarvadnya I believe both creativeInstanceId.total.count
and creativeInstanceId.{uuid}.{views/clicks}
are expected. I suspect we may be seeing different things based on the p3a debug flags that are added, maybe @DJAndries can clarify. You could also verify in the histograms viewer instead of local state
@kylehickinson This is what I see on Histograms (p3a)
Seeing zero there means you didn't view any sponsored images within the p3a rotation
@kylehickinson: In Histograms (p3a) the metrics value is always 0 even after viewing 4 to 6 NTP SI
Here's what I see on 1.65.73 after viewing a NTP and clicking on its logo:
@kylehickinson The creativeInstanceId.total.count
value will always be 0
even when I view n number of NTP SI's, this value turns 1
only when I click on NTP SI logo
Steps that I have followed:
Settings
-> BraveCoreSwitches
-> Enable the switch Express Rotation Interval
, enter the 30 in the rotation interval text box and click on SaveSettings
-> BraveCoreSwitches
->Enable Don't randomize upload intervals
creativeInstanceId.total.count =0
https://github.com/brave/brave-ios/issues/8673#issuecomment-1994793010creativeInstanceId.total.count =1
Also, click and land events recorded but there is no view event step 9 | step 9 |
---|---|
Thanks I'll double check the view events, maybe there is something odd going on with those. I think that's out of scope with this ticket in particular though which simply ensures that things are reported even when you don't visit NTPs, we can open a new ticket for the view
events not showing up without clicking though
Verification PASSED on Brave Nightly version 1.65.77
running iPhone 8 - iOS version 16.7.5
creativeInstanceId.total.count
value is 1
on Histogram (p3a)
page, but the value 1
is shown only when the NTP SI logo is clicked, which is incorrect, the value should 1
even for viewing NTP SI. Hence logged the follwing issues.Logged 2 follow up issues:
https://github.com/brave/brave-ios/issues/8794 https://github.com/brave/brave-browser/issues/36794
We are receiving more NTP-SI view reports compared to total count reports. For all other platforms the number of total count reports exceeds the view reports.
It may be the case that the total count metric is not being reported everyday, regardless of if the user viewed a campaign.