There was a chance that a user would simply never load a NTP during their session which means that P3A rotations wouldn't trigger new NTP-SI reports each day. This report was supposed to occur each rotation, not specifically per NTP view.
Summary of Changes
This pull request fixes #8673
Submitter Checklist:
[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
[x] Light & dark mode
[x] Different size classes (iPhone, landscape, iPad)
[x] Different dynamic type sizes
Test Plan:
Prefix: Visit debug settings > BraveCore Switches and set express rotation interval of some short amount (and optionally do not randomize)
Load app as usual, view a NTP-SI and verify it reports correctly
Load a website in the current tab and kill the app
Re-open the app and do not visit any NTP (including non-SI versions), verify NTP-SI data is still reported correctly
There was a chance that a user would simply never load a NTP during their session which means that P3A rotations wouldn't trigger new NTP-SI reports each day. This report was supposed to occur each rotation, not specifically per NTP view.
Summary of Changes
This pull request fixes #8673
Submitter Checklist:
NSLocalizableString()
Test Plan:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement