brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 441 forks source link

[ads] Unify iOS kBraveNTPBrandedWallpaper #8702

Closed tmancey closed 7 months ago

tmancey commented 8 months ago

Summary of Changes

This pull request fixes #8701

Requires https://github.com/brave/brave-core/pull/21751

Submitter Checklist:

Test Plan:

We should also test the default values if the Griffin feature does not exist. Default value is 2 for BraveNTPBrandedWallpaper/initial_count_to_branded_wallpaper and 3 for BraveNTPBrandedWallpaper/count_to_branded_wallpaper.

And that the position is persisted across browser restarts.

Screenshots:

Reviewer Checklist:

tmancey commented 8 months ago

Tests are failing because we first need to merge brave-core changes with https://github.com/brave/brave-core/pull/21751