Brave Talk will mute / unmute when minimized and spacebar is pressed.

brave / brave-ios

Brave iOS Browser

Mozilla Public License 2.0

1.7k stars 441 forks source link

Description:

If I minimize Brave Talk in Brave so I can use the browser, hitting the space bar while in another window (e.g. typing an email) will also mute/unmute the microphone.

Steps to Reproduce

Start a Brave Talk call
Press the down arrow in the top-left hand corner to mimimize BVrave talk
In another window (or address bar) begin typing. You’ll hear it mute/unmute if the sound is on.

Expected result:

Hotkeys/shortcuts for Brave Talk should not be active when Brave Talk is minimized.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% of the time.

Brave Version:

Version 1.61.1 (24.1.4.20)

Can you reproduce this issue with the most recent build from TestFlight? Yes.
Can you reproduce this issue with the previous version of the current build from TestFlight? N/A
Can you reproduce this issue with the current build from AppStore? Yes.

Device details:

IPadOS 17.3

Cc: @kylehickinson

Verified on iPad Air using version(s):

Device/OS: iPad Air / iPadOS 16.7.2
Brave build: 1.63 (161)
BraveCore: 1.63.161 (122.0.6261.57)

STEPS:

Launch Brave
Connect physical keyboard
Go to talk.brave.com > Start a call
Tap ∨ in the top left corner to minimize Brave Talk window
Open NTP > URL search bar
Start typing > Tap the Spacebar > Verify

ACTUAL RESULTS:

Verified that Mic Mute/Unmute is not triggered when tapping the Spacebar on the keyboard while Brave Talk is in use

Repro with 1.62.1

https://github.com/brave/brave-ios/assets/128532965/093713d1-e466-4ae4-9d75-6a40a8874125

Verified with 1.63

https://github.com/brave/brave-ios/assets/128532965/e7845674-0f40-43f1-910d-c610f2769e8c

brave / brave-ios