brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.7k stars 440 forks source link

Fix #8738, #8708: Fix memory leak in `SettingsViewController` #8739

Closed StephenHeaps closed 9 months ago

StephenHeaps commented 9 months ago

Summary of Changes

This pull request fixes #8738, fixes #8708

Submitter Checklist:

Test Plan:

  1. Restore a wallet with NFTs
  2. Once Portfolio is shown, dismiss wallet
  3. Tap ... -> Settings -> Web3 (must be done through browser settings)
  4. Reset wallet
    • Do not quit / relaunch the app
  5. Re-open wallet and restore the same wallet from step 1
  6. Open NFT tab, enable auto-discovery and wait
  7. Observe no assets are duplicated, NFTs displayed in a grid as expected

Screenshots:

Reviewer Checklist: