[Follow up to #8701] `NTP SI` is shown on 2nd attempt after browser launch, and then on every 4th instead of every 3rd attempt - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 441 forks source link

[Follow up to #8701] `NTP SI` is shown on 2nd attempt after browser launch, and then on every 4th instead of every 3rd attempt #8741

Closed hffvld closed 7 months ago

hffvld commented 7 months ago

Description:

Follow-up to #8701

Steps to Reproduce

Install and launch Brave
Wait until landed on NTP
Open new NTP (2nd one in total) > Confirm that SI is opened
Open 4 more NTP > Observe that the next SI is shown on every 4th NTP

Actual result:

NTP SI is shown on the 2nd attempt after browser launch, and then on every 4th instead of every 3rd attempt.

1	2

https://github.com/brave/brave-ios/assets/128532965/db302e73-5da2-4191-8925-9659d0e503eb

Expected result:

As per https://github.com/brave/brave-ios/pull/8702#issue-2100748362:

NTP SI is shown on 2nd NTP for BraveNTPBrandedWallpaper/initial_count_to_branded_wallpaper
NTP SI is shown on every 3rd NTP for BraveNTPBrandedWallpaper/count_to_branded_wallpaper

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.62 (24.2.6.11)
BraveCore: 1.62.158 (121.0.6167.139)

Can you reproduce this issue with the most recent build from TestFlight? YES
Can you reproduce this issue with the previous version of the current build from TestFlight?
Can you reproduce this issue with the current build from AppStore? YES

Device details:

iPhone 14 / iOS 17.4 Beta

Website problems only:

did you check with Brave Shields down?
did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

hffvld commented 7 months ago

I experienced an internet connection problem during the issue creation, and a duplicate issue was created. So, closing this since #8740 is the original issue.