This PR prepares for the list_catalog.json and fixes a number of issues during launch
Don't compile custom filter lists upon launch (this could have been causing load hangs for people with custom filter lists)
Explicitly don't compile shown filter lists upon launch. (it will compile hidden filter lists but those do not appear until we switch to list_catalog.json). There is no change in behaviour because there was a bug in the code which causes no filter lists to compile
Add signposts for some better launch profiling
Note except for part 2, none of this should affect launch performance. Later work will be done to improve launch performance (we will attempt to save and load dat files in the future which should give a performance boost)
Submitter Checklist:
[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
[x] Light & dark mode
[x] Different size classes (iPhone, landscape, iPad)
Summary of Changes
This PR prepares for the list_catalog.json and fixes a number of issues during launch
Note except for part 2, none of this should affect launch performance. Later work will be done to improve launch performance (we will attempt to save and load dat files in the future which should give a performance boost)
Submitter Checklist:
NSLocalizableString()
Test Plan:
Test adblocking and launch performance.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement