Allow native Jitsi SDK on dev and staging Brave Talk hosts - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.7k stars 440 forks source link

Allow native Jitsi SDK on dev and staging Brave Talk hosts #8754

Closed stoletheminerals closed 9 months ago

stoletheminerals commented 9 months ago

Summary of Changes

This pull request fixes https://github.com/brave/brave-ios/issues/8753 Removing if condition to allow dev and staging Brave Talk servers to launch native Jitsi SDK. We already limit where this script can be injected, so there is no need for an additional check. The current list of allowed hosts is https://github.com/brave/brave-ios/blob/0d7f871621554e81588e90767c9c881a70506e05/Sources/Brave/Frontend/Browser/DomainUserScript.swift#L46-L49

Submitter Checklist:

[ ] Unit Tests are updated to cover new or changed functionality
[ ] User-facing strings use NSLocalizableString()
[ ] New or updated UI has been tested across:
- [ ] Light & dark mode
- [ ] Different size classes (iPhone, landscape, iPad)
- [ ] Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).

stoletheminerals commented 9 months ago

@mrose17 let me know if don't actually want some of these hosts to be enabled for the native sdk. I'll remove it from the injection list

mrose17 commented 9 months ago

With respect to the list of sites, it probably should be

talk.brave.com
https://talk.bravesoftware.com/ (staging)
https://talk.brave.software/ (dev1)
there aren't any beta. domains!