Fix #8768: Add Logging to Track Secure Content State - Githubissues

brave / brave-ios

Brave iOS Browser

https://brave.com

Mozilla Public License 2.0

1.68k stars 440 forks source link

Fix #8768: Add Logging to Track Secure Content State #8769

Closed soner-yuksel closed 4 months ago

soner-yuksel commented 4 months ago

Summary of Changes

Customizing the Logger and adding secure state logging

This pull request fixes brave/brave-browser#36281

This Pr will be also opened in brave-core side

Submitter Checklist:

[x] Unit Tests are updated to cover new or changed functionality
[x] User-facing strings use NSLocalizableString()
[x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes

Test Plan:

Run the application
Go .. dot menu and settings
Find Secure Content Debug at the bottom
Check the logs or share

Screenshots:

https://github.com/brave/brave-ios/assets/6643505/0b3259ca-f3d3-4565-b686-1ac377e5ddaa

Reviewer Checklist:

[ ] Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
[ ] Necessary security reviews have taken place.
[ ] Adequate unit test coverage exists to prevent regressions.
[ ] Adequate test plan exists for QA to validate (if applicable).
[ ] Issue and pull request is assigned to a milestone (should happen at merge time).