brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.68k stars 440 forks source link

Update JitsiSDK to 8.6.3 #8777

Closed soner-yuksel closed 4 months ago

soner-yuksel commented 4 months ago

This resolves couple of bugs we have like joining conferences with many participants.

soner-yuksel commented 4 months ago

This ticket is copy of https://github.com/brave/brave-browser/issues/36353. It is created by the request of Quality Assurance team for tracking purposes of hotfix.

kjozwiak commented 4 months ago

Closing as the above was merged/added into 1.62.1 as per https://bravesoftware.slack.com/archives/C06UXF3KJ/p1709156791608489. QA originally went through the above using a 0.0 build as per https://github.com/brave/qa-resources/issues/559#issuecomment-1961734101, https://github.com/brave/qa-resources/issues/559#issuecomment-1962155578, https://github.com/brave/qa-resources/issues/559#issuecomment-1963509985 & https://github.com/brave/qa-resources/issues/559#issuecomment-1964430570.

@hffvld @Uni-verse we'll need to run through a few spot checks just to make sure that there's no obvious regressions now that the SDK was merged into 1.62.x. I wouldn't waste time going through the same thorough checks as we already verified the SDK via 0.0 but it's definitely worth checking just to make sure it works within 1.62.x. @srirambv mind quickly spot checking the Web3 portion?

We'll probably also need to run through quickly spot check via 1.65.x just to make sure that builds build via brave-core are working well with the new SDK before we uplift into 1.64.x & 1.63.x via https://github.com/brave/brave-core/pull/22344 & https://github.com/brave/qa-resources/issues/559. However, at that point, we can label https://github.com/brave/brave-browser/issues/36353 as QA/No and release-notes/exclude it's technically going out via 1.62.1.

Uni-verse commented 4 months ago

Verified on iPhone 12 running iOS 17.3.1 using version 1.62.1 (24.3.28.21)

Example Example Example Example Example Example Example
IMG_5763 IMG_5764 IMG_5765 IMG_5766 IMG_5767 IMG_5768 IMG_5769
Uni-verse commented 4 months ago

Verified on iPad (7th Gen) running iOS 17.0 using version 1.62.1 (24.3.28.21)

Example Example Example Example Example
IMG_1295 IMG_1296 IMG_1300 IMG_1301 IMG_1305