search

brave / brave-talk

Unlimited private video calls with your friends and colleagues
Mozilla Public License 2.0
123 stars 35 forks source link

Log-in loads 8x8 SSO page #1307

Closed srirambv closed 9 months ago

srirambv commented 11 months ago

Description:

Log-in loads 8x8 SSO page

Steps to Reproduce

  1. Open Brave and select Talk from menu
  2. Create a free call
  3. Open call menu and go to setting
  4. Tap on Name
  5. Tap on Log-in on top right corner, opens 8x8 SSO page

Actual result:

https://github.com/brave/brave-talk/assets/17010094/7fe567ec-842f-4bf2-8091-db78e0d7ba36

Expected result:

No 8x8 login shown on profile

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

All

Device details:

iPad (iOS 16.7.2)

Additional Information

This is iOS only issue for Brave Talk. Android works similar to Desktop just shows the profile name and no Log-in button is shown cc: @iccub @mrose17

mrose17 commented 11 months ago

@srirambv - github appears to have lost the video above.

Regardless, this was fixed in the website version, but the current SDK doesn't have the fix, e.g., IMG_0590

@saghul - could this fix be scheduled for the next SDK release? Thank you!

saghul commented 11 months ago

Will do.

saghul commented 10 months ago

This will be part of SDK 8.6.1, we are hiding the Login option.

mrose17 commented 10 months ago

Great! I will add the blocked label, and we will QA it after we have a TestFlight version with the new SDK!

saghul commented 10 months ago

Small correction, the version with the fix is 8.6.2, released today.

mrose17 commented 10 months ago

@srirambv - grab a copy of 0.0 (24.1.19.16) and try it out... thanks!

srirambv commented 9 months ago

Verified no Login option in profile details page

https://github.com/brave/brave-talk/assets/17010094/2d759646-15a8-4e2a-a5e8-7ee2e1f6740d