search

brave / brave-talk

Unlimited private video calls with your friends and colleagues
Mozilla Public License 2.0
123 stars 35 forks source link

Brave Talk Marvin to staging #1360

Closed mrose17 closed 9 months ago

mrose17 commented 9 months ago

Brave folks: see https://docs.google.com/document/d/1Cb15YelULNfjM50eanx6asdn4F354ufxkTPvtpNSZDM for the specification and https://github.com/brave-intl/brave-talk-server/pull/50 for the changes to the Brave Talk server

Briefly: a premium moderator may turn on transcriptions (speech-to-text) in addition to A/V recording. As with A/V recordings, the moderator has access to a transcription file that "lives" for 24h (with links on the home page). Unlike A/V recordings, all participants receive incremental transcription "chunks", which are visible to "Brave Leo", thereby allowing the participants to (1) ask what happened before they joined and (2) ask Leo questions related to the call.

github-actions[bot] commented 9 months ago

[puLL-Merge] - brave/brave-talk@1360

Description

This pull request makes changes to the codebase in the src/components/InCall.tsx, src/components/Recordings.tsx, src/environment.ts, src/hooks/use-call-setup-status.ts, src/i18n/locales/en/translation.json, src/index.tsx, src/jitsi/event-handlers.ts, src/jitsi/lib.ts, src/jitsi/options.ts, src/jitsi/types.ts, src/recordings-store.ts, src/rooms.ts, src/transcripts.ts, and webpack.config.js files. The main changes include adding functionality related to handling transcripts in the Jitsi meetings, updating recording details, and handling transcription events.

Changes ### Changes - Added handlers for transcript events such as `transcriptionChunkReceivedHandler` and `transcribingStatusChangedHandler` in `src/jitsi/event-handlers.ts` - Added a new `TranscriptManager` class in `src/transcripts.ts` to manage transcript related operations - Updated the `upsertRecordingForRoom` function in `src/recordings-store.ts` to handle transcript URLs and expiration times for recordings - Made changes to `src/components/Recordings.tsx` to show options for downloading transcripts along with recordings - Introduced new translations in `src/i18n/locales/en/translation.json` related to transcription availability - Updated the environment configuration in `src/environment.ts` to handle different Webrtc domain settings - Added new dependencies and functions in various files to support transcript related functionalities

Security Hotspots

  1. The addition of new functionalities related to transcripts and recordings may introduce new security risks, especially if there are vulnerabilities in the handling of transcript URLs and JWT tokens. Careful testing and review are recommended to ensure data security.
  2. The handling of CSRF tokens and authorization headers in the operateOnTranscriptDetails function in src/transcripts.ts should be reviewed to prevent potential security vulnerabilities.
  3. Any user input or external data used in processing transcripts or recordings should be validated and sanitized to prevent possible injection attacks.
github-actions[bot] commented 9 months ago

The following commits were not verified: c6632155e5c8a3bc8d29d2a2ac555da22a3ad5a1 (unsigned) 0f5d7491fb2da2f19b0a2ad0fa1475806c8270a9 (unsigned) 776b8ab40eb8c3fff08a4d5e3d3312dc94708bce (unsigned) 7a8f4b7c59351b37b5d48f804506aca22cc2a5a7 (unsigned) 02ce097f40302b0de9ed20044499469232166680 (unsigned) c44f308fadef62bc16fcdf985c2c361d8cf372b2 (unsigned) e22e64466da0587a6a3e21b8769068bf97151d93 (unsigned) d777a78dd88f5c726c810c3646dd2ac520041041 (unsigned) 368d8fe59d629410083785d3118f640308541c5c (unsigned) af3e579d9d35779c832515bc1859d7486bc937ed (unsigned) d587d45e63c687687c03efc0d7ef625e41e8b82e (unsigned) a698434c156bebee2f16a709f5a1de6f944b9ab3 (unsigned)

DJAndries commented 9 months ago

Superseded by https://github.com/brave/brave-talk/pull/1367