brave / brave-talk

Unlimited private video calls with your friends and colleagues
Mozilla Public License 2.0
123 stars 35 forks source link

Merge main into prod #1451

Closed mrose17 closed 4 months ago

github-actions[bot] commented 4 months ago

[puLL-Merge] - brave/brave-talk@1451

Description

This PR updates various dependencies and introduces a new feature for displaying meeting transcripts. It also includes some minor improvements and bug fixes.

Changes ### Changes 1. `.github/workflows/*.yml`: - Updated `actions/checkout` to version 4.1.7 - Updated `github/codeql-action` to version 3.25.10 2. `.node-version`: - Updated Node.js version to 20.14.0 3. `package.json`: - Updated various dependencies, including React, TypeScript, and development tools - Added `@brave/leo` dependency 4. `src/App.tsx`: - Added logic to handle transcript display based on URL route 5. `src/components/Recordings.tsx`: - Added functionality to handle transcript display when clicking on a transcript link 6. `src/components/Transcript.tsx`: - New component for displaying meeting transcripts 7. `src/components/WelcomeScreen.tsx`: - Updated to include transcript display functionality 8. `src/css/inter.css`: - Added "Inter Variable" font face 9. `src/downloaded-transcript.ts`: - New file for handling transcript parsing and data structures 10. `src/get-language-detector.ts`: - Updated language detection to handle "ja-JP" locale 11. `src/hooks/use-subscribed-status.ts`: - Added logic to remove order parameters from URL after processing 12. `src/i18n/locales/en/translation.json` and `src/i18n/locales/jp/translation.json`: - Added new translations for transcript-related text 13. Added new SVG images for UI elements

Possible Issues

  1. The transcript display feature might not work correctly if the API endpoint for fetching transcripts is not properly set up or if the transcript data format changes.

  2. The new font face "Inter Variable" might not load correctly if the font file is missing or incorrectly referenced.

  3. The language detection update for Japanese might cause unexpected behavior for users with non-standard locale settings.

Security Hotspots

  1. The transcript parsing logic in src/downloaded-transcript.ts should be carefully reviewed to ensure it doesn't introduce any vulnerabilities when processing potentially malicious input.

  2. The URL manipulation in src/hooks/use-subscribed-status.ts should be checked to ensure it doesn't introduce any security risks related to URL parsing or history manipulation.

Overall, this PR introduces significant new functionality with the transcript display feature, while also keeping dependencies up-to-date. The changes appear to be well-structured and include necessary updates to related components and translations.