search

brave / brave-talk

Unlimited private video calls with your friends and colleagues
Mozilla Public License 2.0
123 stars 35 forks source link

Update actions/setup-node action to v4.1.0 #1533

Closed renovate[bot] closed 2 weeks ago

renovate[bot] commented 2 weeks ago

This PR contains the following updates:

Package Type Update Change
actions/setup-node action minor v4.0.4 -> v4.1.0

Release Notes

actions/setup-node (actions/setup-node) ### [`v4.1.0`](https://redirect.github.com/actions/setup-node/compare/v4.0.4...v4.1.0) [Compare Source](https://redirect.github.com/actions/setup-node/compare/v4.0.4...v4.1.0)

Configuration

📅 Schedule: Branch creation - " 0-4 * 3" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR was generated by Mend Renovate. View the repository job log.

github-actions[bot] commented 2 weeks ago

[puLL-Merge] - actions/setup-node@v4.0.4..v4.1.0

Description

This PR introduces several changes to improve the caching mechanism and GHES detection in the setup-node action. The main changes include incorporating the CPU architecture into the cache key, refining the GHES detection logic, and updating dependencies.

Changes ### Changes 1. `.github/workflows/publish-immutable-actions.yml`: - Updated the trigger for the workflow from `release: [created]` to `release: [published]`. - Updated the `actions/publish-immutable-action` version from `0.0.1` to `0.0.3`. - Removed the `github-token` input. 2. `__tests__/cache-restore.test.ts`: - Added `os` module import and mocking of `os.arch()` function. - Updated test cases to include CPU architecture in the cache key. 3. `__tests__/cache-utils.test.ts`: - Added new test cases for the `isGhes()` function to cover different scenarios. 4. `__tests__/data/pnpm-lock.yaml`: - Updated the pnpm lockfile version and dependencies. 5. `dist/cache-save/index.js` and `dist/setup/index.js`: - Updated the `isGhes()` function to handle GitHub Enterprise Cloud and localhost scenarios. - Incorporated CPU architecture into the cache key generation. 6. `src/cache-restore.ts`: - Added CPU architecture to the cache key generation. 7. `src/cache-utils.ts`: - Refined the `isGhes()` function to exclude GitHub Enterprise Cloud and localhost scenarios.

Possible Issues

The changes to the GHES detection logic might affect environments that were previously incorrectly identified as GHES. It's important to test this change thoroughly in various environments to ensure correct behavior.

Security Hotspots

No significant security hotspots were identified in this change. The modifications to the GHES detection logic and cache key generation do not introduce any apparent security risks.