Closed srirambv closed 1 year ago
@johnhalbert - Sri shows both the problem and points to a solution.
When we display Failed to connect wallet
, there should be some additional text saying Please click on the Wallet icon to try again.
@mattmcalister / @jamesmudgett - do you agree? can we find out who owns https://support.brave.com/hc/en-us/articles/4415497656461-Brave-Wallet-FAQ and ask them to add an FAQ: "What to do if a site says that it failed to connect to the wallet?", and the answer, of course is, if you want to try again, please click on the wallet icon.
@srirambv - FYI: it isn't possible for the site to trigger the wallet widget to appear (if a website could do that, they'd be able to perform a denial of service attach).
Yes, this seems good:
Failed to connect wallet. Please click on the Wallet icon to try again.
[Help with Brave Wallet](https://support.brave.com/hc/en-us/articles/4415497656461-Brave-Wallet-FAQ)
Can we say Failed to connect wallet. Please reload the page and try again
? Since we are looking for wallet connect on page load. There isn't anything being done on the wallet icon itself
@mattmcalister @srirambv @mrose17 pushed this change to web3-on-reactify
branch with a combination of text from @mattmcalister and @srirambv. Reads:
Failed to connect to wallet. Please reload the page and try again
[Help with Brave Wallet](https://support.brave.com/hc/en-us/articles/4415497656461-Brave-Wallet-FAQ)
@srirambv - we think this is addressed. please retest. thanks!
Looks fixed. Text change is as per https://github.com/brave/brave-talk/issues/819#issuecomment-1518274449 and Help with Brave Wallet
links to https://support.brave.com/hc/en-us/articles/4415497656461-Brave-Wallet-FAQ
Closing the issue
Description
Failed to connect wallet message when Wallet onboarding is triggered
Steps
https://talk.brave.software
and click onStart Web3 Call
Failed to connect wallet
message doesn't trigger a page refresh automatically to connect to WalletActual Result
https://user-images.githubusercontent.com/17010094/233549838-16091500-612c-4489-93c1-61feb9ef4ee8.mp4
Expected Result
Once onboarding is done closing wallet tab or switching back to Talk tab should trigger page refresh to connect Wallet and create the call
cc: @mrose17