brave / brave-ui

List of reusable React components to empower your brave UI
https://brave.github.io/brave-ui
Mozilla Public License 2.0
472 stars 136 forks source link

Remove muli #607

Closed petemill closed 2 years ago

petemill commented 2 years ago

Changes

Removes all occurances of the Muli font and replaces with Poppins. The biggest change is in the theme file, which other projects use, but really mainly (only?) brave-core.

Test plan

Make sure storybook runs with no error. I verified this. Main visual (manual) tests will be in brave-core.

Link / storybook path to visual changes

Integration

boocmp commented 2 years ago

I don't actually understand what is StoryBook and how I can use it. The last time I showed an build from my PR to @aguscruiz, he recommended to change the font weight for Poppins. I'm not sure, but it looks like we need to change the weights in the storybook.

petemill commented 2 years ago

@boocmp I think we'll need to build brave-core with this brave-ui ref in order to see what changes would be neccessary, and I think most or all of those changes would be in brave-core code. I'll push to your branch in https://github.com/brave/brave-core/pull/12933 an update to the brave-ui ref so that we can get a browser build and Storybook