search

brave / brave-variations

Resources to compile, publish and inspect the variations seed file
Mozilla Public License 2.0
17 stars 17 forks source link

Debounce ad clicked events for 1 second #1059

Open tmancey opened 3 months ago

tmancey commented 3 months ago

Previously we would always debounce click ad events.

btlechowski commented 3 months ago

Verified with

Brave 1.66.115 Chromium: 125.0.6422.112 (Official Build) (64-bit)
Revision a168513c9c84b6ba793d5eac01c725982187aeb4
OS Linux

On 1.66.x the click events are always debounced

[2488:2488:0528/134652.221512:VERBOSE1:new_tab_page_ad_event_handler.cc(103)] New tab page ad: Not allowed as debounced kClicked event for placement id dace5070-a7be-4159-8423-e64d0dc85ad6
[2488:2488:0528/134652.222315:VERBOSE1:new_tab_page_ad_event_handler.cc(144)] Failed to fire new tab page ad kClicked event for placement id dace5070-a7be-4159-8423-e64d0dc85ad6 and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e

Verified with

Brave 1.67.97 Chromium: 125.0.6422.112 (Official Build) beta (64-bit)
Revision 22cab228de5901daf663c40d4c9f6f1ef3e36358
OS Linux

image

debounced within XXs

[4218:4218:0528/135906.016255:VERBOSE1:new_tab_page_ad_event_handler.cc(103)] New tab page ad: Not allowed as debounced kClicked event for placement id ee0ca610-e270-4ce6-aa27-ad3995d2fcfa
[4218:4218:0528/135906.016758:INFO:CONSOLE(0)] "Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.", source:  (0)
[4218:4218:0528/135906.019311:VERBOSE1:new_tab_page_ad_event_handler.cc(144)] Failed to fire new tab page ad kClicked event for placement id ee0ca610-e270-4ce6-aa27-ad3995d2fcfa and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e
[4218:4218:0528/135906.126321:VERBOSE2:tab_manager.cc(248)] Created tab with id 1

not debounced after XXs

[4218:4218:0528/140036.558613:VERBOSE1:confirmations.cc(77)] Successfully added click confirmation for new_tab_page_ad with transaction id 7f76769d-20b4-40da-aceb-681dd3adb9b0 and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e to the queue
[4218:4218:0528/140036.558639:VERBOSE1:confirmations.cc(88)] Process click confirmation for new_tab_page_ad with transaction id 7f76769d-20b4-40da-aceb-681dd3adb9b0 and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e in 0 hours, 0 minutes, 5 seconds at 14:00:41.542
btlechowski commented 3 months ago

Verified on Brave v1.67.99 on Lenovo TB-8506FS (Android 11.0)

Verified study is enabled image

debounced within XXs

19:40:33.321  V  [VERBOSE1:inline_content_ad_event_handler.cc(108)] Inline content ad: Not allowed as debounced kClicked event for placement id 4208f8ef-7ac9-41d9-bca2-bc2c26a89994
19:40:33.321  V  [VERBOSE1:inline_content_ad_event_handler.cc(181)] Failed to fire inline content ad kClicked event for placement id 4208f8ef-7ac9-41d9-bca2-bc2c26a89994 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8

not debounced after XXs

19:35:55.928  V  [VERBOSE3:inline_content_ad_handler.cc(211)] Clicked inline content ad with placement id d5d39a97-ef6b-4ed6-b1cf-8d95e8f8f037 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
19:35:55.933  V  [VERBOSE3:account.cc(166)] Successfully processed deposit for inline_content_ad with creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 and click valued at 0
19:35:55.933  V  [VERBOSE1:confirmations.cc(43)] Confirming click for inline_content_ad with transaction id c42fe437-cf07-4797-92f3-d444054916b7 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
19:35:55.942  I  Start proc 32408:com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:12/u0ai12 for  {com.brave.browser_beta/org.chromium.content.app.SandboxedProcessService0:12}
19:35:55.952  V  [VERBOSE1:confirmations.cc(77)] Successfully added click confirmation for inline_content_ad with transaction id c42fe437-cf07-4797-92f3-d444054916b7 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 to the queue
19:35:55.956  V  [VERBOSE1:confirmations.cc(88)] Process click confirmation for inline_content_ad with transaction id c42fe437-cf07-4797-92f3-d444054916b7 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 in 0 hours, 0 minutes, 5 seconds at 19:36:00.952
19:35:56.043  I  version=125.1.67.99 (426709920) minSdkVersion=26 isBundle=false processName=com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:12 isIsolatedProcess=true
19:35:56.292  I  Killing 32360:com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:11/u0a311i-8989 (adj 0): isolated not needed
19:35:56.312  V  [VERBOSE2:tab_manager.cc(253)] Tab id 763345823 did change
19:35:56.328  V  [VERBOSE1:ad_handler.cc(144)] Maybe land on page for https://brave.com/careers in 5 s
19:35:56.329  V  [VERBOSE1:inline_content_ad_handler.cc(132)] Purging orphaned inline content ad placements for tab id 763345823
19:35:56.329  V  [VERBOSE1:inline_content_ad_handler.cc(137)] There are no orphaned inline content ad placements for tab id 763345823
19:35:56.477  I  Start proc 32436:com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:13/u0ai13 for  {com.brave.browser_beta/org.chromium.content.app.SandboxedProcessService0:13}
19:35:56.591  I  version=125.1.67.99 (426709920) minSdkVersion=26 isBundle=false processName=com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:13 isIsolatedProcess=true
19:35:57.067  I  Killing 32408:com.brave.browser_beta:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:12/u0a311i-8988 (adj 0): isolated not needed
19:35:57.759  V  [VERBOSE3:inline_content_ad_handler.cc(211)] Clicked inline content ad with placement id d5d39a97-ef6b-4ed6-b1cf-8d95e8f8f037 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
1
btlechowski commented 3 months ago

Verification passed on 1.68.58 on iPhone 13 Pro Max (iOS 17.5)

Verified feature was enabled

image

debounced within XXs

info    20:24:26.786628+0200    Client  [ads] Inline content ad: Not allowed as deduplicated kClicked event for placement id 840733a8-c26e-4005-b73f-b38c5e0911a2
info    20:24:26.786650+0200    Client  [ads] Failed to fire inline content ad kClicked event for placement id 840733a8-c26e-4005-b73f-b38c5e0911a2 and creative instance id 1d87cb97-3f55-4a3d-bce1-1c841f39b6f8

not debounced after XXs

info    20:21:45.450439+0200    Client  [ads] Clicked inline content ad with placement id eceb7d36-f669-413e-8dce-d85d63543ef7 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
info    20:21:45.450439+0200    Client  [ads] Clicked inline content ad with placement id eceb7d36-f669-413e-8dce-d85d63543ef7 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372