brave / brave-variations

Resources to compile, publish and inspect the variations seed file
Mozilla Public License 2.0
17 stars 17 forks source link

Canvas related kill switches #1067

Closed atuchin-m closed 1 month ago

atuchin-m commented 1 month ago

For https://github.com/brave/brave-variations/issues/1060 PR to production: https://github.com/brave/brave-variations/pull/1068

Both features need to be disabled.

We use max_version: 125.* because cr126 got the fix in the code, so we don't need to cover it. min_version isn't set because Finch config disables:

  1. EvictionUnlocksResources for >= cr124 (for <= cr123 it's disabled in the code )
  2. Canvas2DHibernation for all the revisions.

P.S. Chrome has 2 separate studies, but it looks less reliable.

Steps to reproduce: https://issues.chromium.org/u/0/issues/341105739

kjozwiak commented 1 month ago

Win 11 x64 verifications

Nightly - CanvasKillSwitches:Disabled_EmergencyKillSwitch

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.25 Chromium: 125.0.6422.60 (Official Build) nightly (64-bit)
-- | --
Revision | aa179dbee72ac0ca0412be64803ecbe931bb3a9e
OS | Windows 11 Version 23H2 (Build 22631.3593)
Broken Fixed
Nightly1 nightly3
nightly2 nightly4

Release - CanvasKillSwitches:Disabled_EmergencyKillSwitch

Brave | 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)
-- | --
Revision | de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS | Windows 11 Version 23H2 (Build 22631.3593)
Broken Fixed
release1 release3
release2 release4
kjozwiak commented 1 month ago

Pixel 6 running Android 14 verifications

Release - CanvasKillSwitches:Disabled_EmergencyKillSwitch

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)
--- | ---
Revision | de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS | Android 14; Build/AP21.240305.005; 34; REL
Broken Fixed
Screenshot_20240521-180907 Screenshot_20240522-005747
Screenshot_20240522-005253 Screenshot_20240522-010254