search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

favicon from closed tab comes up on new website tab? #10176

Closed patrick99e99 closed 6 years ago

patrick99e99 commented 7 years ago

I was visiting a webpage: https://investorshub.advfn.com/boards/read_msg.aspx?message_id=133353270

I had my my mouse on the "next" link on the right side of the page (under the search bar), and was trying to click it to move to the next message in the thread. After the webpage finished loading, the content jumps--- so when I clicked "next", the content had shifted up causing me to click on "E*Trade" instead of the Next link.

A new window popped opened up with etrade.. Once I saw I was on E*Trade, I closed the window, as it was not my intention to go there...

A few minutes later, I clicked a different link from a slack channel, and I noticed that the Favicon for that website had somehow become E*Trade's favicon!!!

bsclifton commented 7 years ago

~Thanks for the report, @patrick99e99 😄 This issue is a duplicate of https://github.com/brave/browser-laptop/issues/1646~

~Since you have better steps, I'll update the original issue and give it a +1 on your behalf 😄~

bsclifton commented 7 years ago

After re-reading, I was mistaken: this appears to be different (but related). Re-opening 😄

LaurenWags commented 7 years ago

Just saw this on 0.18.24. I had 2 pinned tabs (one of which was github.com) and about 25 tabs open. I clicked on the non-pinned tab next to my pinned tabs and started closing the tabs in quick succession (using the x icon on the tab, not cmd+w or right click to close tab). After closing about 12-13 tabs I noticed that my pinned tab was now displaying the wrong favicon: screen shot 2017-08-31 at 2 39 31 pm

LaurenWags commented 7 years ago

+1 from community: https://community.brave.com/t/tab-icon-changing-to-last-closed-tab/6103

LaurenWags commented 6 years ago

+1 from community https://community.brave.com/t/wrong-icon-on-last-tab-on-osx/21371

LaurenWags commented 6 years ago

Reproduced on 0.22.716 - had multiple tab pages open, Opened Preferences, enabled Metamask, after the metamask page opened, I closed it and Preferences got the MetaMask favicon: screen shot 2018-05-18 at 9 18 41 am

srirambv commented 6 years ago

This looks similar to https://github.com/brave/browser-laptop/issues/6513 which has been an issue for a while.

LaurenWags commented 6 years ago

yep - I definitely think https://github.com/brave/browser-laptop/issues/10176#issuecomment-390204464 is a case of #6513. thanks!