luixxiul
commented
7 years ago Re KissAnime: it is technically an ad though it is a pop-up messageBox. Also currently we don't block the 1st party ad. And, unless KissAnime is a pirate site, it is not worth fixing.
Re twitch: if you allow 3rd party cookie on the site via the lion icon, the video is loaded.
Brave-Matt
Did you search for similar issues before submitting this one? Yes, see related issues at bottom, no issues for exact same problems though.
Describe the issue you encountered: Some things that should not be are (only partly? idk.. the player is still visible but nothing plays) blocked by Brave Shields. For example, the videos in the feed under a twitch stream, only sit on a black screen which is pictured below. Another problem spot is on KissAnime. All the videos and players that I have looked at on this site, still are able to pop-out some site or something when you click Play on the video, like they are supposed to... for a non-ad-blocking user. However, this obviously is supposed to be blocked with Brave Shield. On top of this, it seems that some players are ~not able to, or~ not able to efficiently, load videos while Brave Shield is on. For example, Kimi No Na Wa on KissAnime is one where everytime I click Play (only happens once per page load, so refreshing the page will cause pop-out to come again) the pop-out site that is set to appear, still comes and is not blocked by Brave Shield. Then after closing this, and returning to the page, if you click to Play the video again it will show a loading sign but this seems to show ~endlessly and never actually load the video~ much longer than it does without Shield being on, seeing as I was able to sit on a black screen with the loading symbol for 2 mins, but as soon as I turned of Brave Shield, the video loaded fine. When going to any of these pages with Brave Shield turned off, the videos load fine, and obviously the pop-outs on KissAnime still happen, unless you use another adblocker.
TL;DR something with Brave Shield, is blocking the videos in the feed on Twitch streams (under a stream, in the channel posts if you scroll down), and on other sites, like KissAnime, pop-outs are not blocked and videos will ~not~ take much longer to load occasionally while Brave Shield is on, it seems.
EDIT: I also feel it is worth noting that usually the extra loading time that it takes while Shield is on, is either much smaller than two minutes or, as I just found out, does not happen at all. After making this post I found that the videos do not always take longer to load and I am not sure what causes them to take longer vs. not take longer, but the pop-up ads are still being displayed either way.
Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
Brave Version (revision SHA): Brave 0.18.14 rev ad92d02 Muon 4.3.6
Steps to reproduce:
Actual result: Videos are not loading/playing... Pop-out ads are showing.
Expected result: Videos load and then play once Play is clicked, pop-out ads are blocked and do not show while Brave Shields are up.
Will the steps above reproduce in a fresh profile? If not what other info can be added? Yes
Is this an issue in the currently released version? Yes
Can this issue be consistently reproduced? Yes
Extra QA steps: What is this ^^(QA Steps)??
Screenshot if needed:
Twitch videos not loading....