search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Touch input: Sometimes can't access the tab X button #10506

Open JaneSmith opened 7 years ago

JaneSmith commented 7 years ago

I am running version 0.18.22 (d850e28) on Windows 10.

I experience poor touch usability in general. There are various issues, and I feel this is likely an area that hasn't been focused on so far. There are other open issues about other touch issues, so I'll just focus on a specific one here.

It's a little bit hard to explain, but sometimes it seems to be impossible to close tabs, as the X button does not appear when tapping the tab in the place that it should be.

As far as I can tell, this issue occurs when opening a new tab (e.g. by right-clicking a link and choosing to open it in a new tab), or when closing a tab and falling back to the previous one. The X button does not appear on the newly-focused tab, and it cannot be closed.

The issue can be fixed by switching to a different tab and then back again. That causes the X button to be visible, and it can be touched to close the tab. However, that is annoying to have to do every time.

luixxiul commented 7 years ago

You could change the UI scale on about:preferences#advanced. Let me know if it improves usability, thanks.

https://github.com/brave/browser-laptop/issues/6125

JaneSmith commented 7 years ago

Changing that setting generally makes it a little bit easier to physically touch in the correct place, and I do feel like I'm able to close tabs a bit more often now... but I am still convinced that there is an actual bug here.

Sometimes, tapping the right side of a tab makes the X button appear, and tapping again clicks that X button and closes the tab. That works fine. Sometimes.

But other times, tapping the right side of a tab does nothing - the X button does not appear. I can keep tapping over and over and over and over again, and nothing happens. The X button does not appear, and the tab does not close. This seems to be a bug.

I am forced to switch to a different tab and back again - then tapping reveals the X button correctly.

bsclifton commented 7 years ago

@JaneSmith what is your DPI set to? You can right click the desktop and pick "Display Settings". That should show a screen that has a percentage for Scale and Layout. I'm guessing this value (for you) is over 100%. We do have some high DPI issues which you may be experiencing

Here's a pic of the setting: screen shot 2017-08-15 at 9 02 10 am

JaneSmith commented 7 years ago

My DPI was set to 150%. However, I tried changing it to 100% and I can still reproduce this issue.

bsclifton commented 7 years ago

@JaneSmith one last thing to try... if you change your DPI, please be sure to log out and log back in. If that fixes the issue then it's definitely DPI related (after you check, don't forget to turn back to 150% and then log out / log back in)

I'm looking at some DPI issues right now and I am hoping this is related. Thanks for your time 😄

JaneSmith commented 7 years ago

I gave that a try, and can still reproduce it. I changed my DPI setting to 100%, logged out, rebooted, logged in, restarted Brave, and the issue is still there.

I've noticed that there are three ways to fix the tab when it becomes bugged like this:

  1. Do a long press on the tab to open its context menu.
  2. Touch/focus the URL bar.
  3. Change to a different tab and back.

All of the above three things fix the tab and make the X button appear again, and I can click it and close the tab. But unless I do these things, no amount of tapping on the tab ever lets me close it.

Brave-Matt commented 6 years ago

+1/related: #14864