search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

displayed Brave wallet address and QR code do not have the same value after restoring wallet #12170

Closed LaurenWags closed 6 years ago

LaurenWags commented 6 years ago

Test plan

  1. Create a BAT wallet (does not have to have funds). Save recovery file for this wallet.
    1. Set profile aside and create a clean profile.
    2. Enable payments, grab screenshots of wallet addresses and QR codes for currencies.
    3. restore wallet from step 1.
    4. Go to the Add Funds dialog and verify wallet addresses against QR codes.

Original issue description

Description

Sometimes the displayed Brave wallet address (for any currency: BTC, ETH, BAT, LTC) does not match the QR code value. I have only been able to reproduce this on a recovered wallet.

Reported via community: https://community.brave.com/t/alphanumeric-address-qr-code-address-when-i-add-funds/11613

Steps to Reproduce

  1. Create a BAT wallet (does not have to have funds). Save recovery file for this wallet.
  2. Set profile aside and create a clean profile.
  3. Enable payments, grab screenshots of wallet addresses and QR codes for currencies.
  4. restore wallet from step 1.
  5. Go to the Add Funds dialog and verify wallet addresses against QR codes. QR codes match step 3 but displayed wallet addresses are for the restored wallet.

Actual result: When backup words are not displayed correctly because you restored your wallet, your QR code address does not match your displayed wallet address. Ex: Displayed value is in image below. However, if you scan the QR code, you will get a different value of bitcoin:13JoDbYTG9RQZkuDUhtKHY8B7vHAUYa3Ni screen shot 2017-12-04 at 5 02 20 pm

Expected result: These should always match.

Reproduces how often: easy

Brave Version

about:brave info: Brave | 0.19.105 rev | 51f8ba5 Muon | 4.5.16

Reproducible on current live release: Yes

Additional Information

LaurenWags commented 6 years ago

Another way to reproduce this: Have a wallet created. Close Brave. Delete your ledger* files and folders from ~/Library/Application Support/brave Reopen Brave New wallet is created. QR code does not match displayed wallet address.

srirambv commented 6 years ago

Works fine on Windows

LaurenWags commented 6 years ago

Reproduced on MacOS and Win by @srirambv using steps from https://github.com/brave/browser-laptop/issues/12170#issuecomment-350373166

NejcZdovc commented 6 years ago

@LaurenWags can we close this one and create another issue, because this issue is about recovery, where we reopen it because of the different scenario. Already looking into this second scenario.

LaurenWags commented 6 years ago

Created https://github.com/brave/browser-laptop/issues/12592 and assigned you @NejcZdovc for issue described in https://github.com/brave/browser-laptop/issues/12170#issuecomment-350373166