search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Copy button is enabled when wallet address for currencies not generated #13974

Closed GeetaSarvadnya closed 6 years ago

GeetaSarvadnya commented 6 years ago

Description

Copy button is enabled when wallet address for currencies not generated

Steps to Reproduce

  1. Enable payments
  2. Ensure wallet address or QR code is not generated for currencies due to server error
  3. Copy button is enabled. Clicking on it shows copied message but nothing is copied into clipboard

Actual result: Copy button is enabled when wallet address for currencies not generated copy button issue

Expected result: Copy button should be disabled if wallet address for currencies is not generated

Reproduces how often: 100%

Brave Version

Brave 0.22.669 V8 6.6.346.24 rev 6cda2e8 Muon 5.2.7 OS Release 10.0.16299 Update Channel Release OS Architecture x64 OS Platform Microsoft Windows Node.js 7.9.0 Brave Sync v1.4.2 libchromiumcontent 66.0.3359.117

Reproducible on current live release: Yes

Additional Information

NejcZdovc commented 6 years ago

@GeetaSarvadnya this will be solved with #13973, where we will add overlay, so that you can't trigger this flow