Add support for BCH/BTG/DASH for funding a BAT wallet

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave

https://www.brave.com

Other

7.94k stars 975 forks source link

Closed mrose17 closed 5 years ago

mrose17 commented 6 years ago

here is the current funding screen:

ideally all of the altcurrencies supported by uphold should be supported. when https://github.com/brave-intl/bat-ledger/pull/215 is merged into master, we can then update the bat-client to use the new GET /v3/wallet endpoint to indicate a desired altcurrency for which an addresses is needed, cf., https://github.com/brave-intl/bat-client/issues/73

jasonrsadler commented 6 years ago

Current supported currencies in uphold: BitCoin BC Cash BC Gold Ethereum BAT Litecoin Dash

Partial: Ripple

'Up and Coming': Ripple Voxel (not cuurently listed in currencies to choose from on dashboard)

Edited after @mrose17 comment below

mrose17 commented 6 years ago

thanks! sadly XRP support is only partial at present.

i don't see Voxel support on uphold, can you provide a link?

jasonrsadler commented 6 years ago

I think it's still in the 'up and coming', XRP does show up in the add funds dropdown on the dashboard

NejcZdovc commented 6 years ago

@bradleyrichter can you please provide mock for this one?

bradleyrichter commented 6 years ago

This is all being replaced by a new iframed Uphold UI. I'm not sure it makes sense to update the existing UI.

mrose17 commented 6 years ago

please update it... just in case. i don't think it's a lot of work.

bradleyrichter commented 6 years ago

@mrose17 you want to add 3 additional coins that are shown in the uphold card screen shot above?

bradleyrichter commented 6 years ago

@NejcZdovc Here is a new layout that allows for more coins:

NejcZdovc commented 6 years ago

@bradleyrichter thank you

currently waiting for work to be finished in bat-ledger/bat-client

iesta commented 6 years ago

EOS should be added too