Key mappings wrong/ignored on MacOS Dvorak Qwerty-⌘

[symulation]

Description

On MacOS I use the software mapped Dvorak keyboard with the option to switch back to the QWERTY layout when the Command Key (⌘) is held down. This works fine in every program I have used except Brave. In Brave holding down ⌘ does not return the keyboard to the QWERTY layout. This means that when I forget that Brave behaves this way I often try to cut text in the browser with ⌘X but since the X key is still mapped to Dvorak I'm really pressing ⌘Q and so Brave quits. Other amusing (but mostly annoying) things happen with other shortcuts.

Steps to Reproduce

1. Turn on Dvorak - QWERTY ⌘ in Preferences. Apple Icon > Preferences > Language & Region > Keyboard Preferences... From the Keyboard Preferences window click the + in the bottom left corner of the window and then select Dvorak - QWERTY ⌘ from the list of English layouts. Make sure it is the selected option before going to step #2. 2. Open Brave. 3. Select some text in the welcome page. Or some text inside the body of any web page. This is important. Everything works within the address bar. The problem only occurs within the body of the browser window. 4. Hold ⌘ and press X.

Actual result: What this does is quit Brave as if ⌘Q had been pressed because Brave is somehow blocking or ignoring the reset to the QWERTY layout that this keyboard layout is supposed to enable when ⌘ is held down.

Expected result: The last step should be the command to cut text (try it in a different program, like Word, Notepad, Chrome, etc.) and since nothing is selected it should do nothing (or cut/copy text if you had selected some).

Reproduces how often: 100%

Brave Version

Brave: 0.23.105 V8: 6.8.275.24 rev: 9a46f8f5cb22a9daf2af21989aed25911aa6f839 Muon: 8.0.9 OS Release: 17.7.0 Update Channel: Release OS Architecture: x64 OS Platform: macOS Node.js: 7.9.0 Brave Sync: v1.4.2 libchromiumcontent: 68.0.3440.84

[bsclifton]

+1 from https://github.com/brave/browser-laptop/issues/9961

Dvorak user: "Command+I" opens search, not italics

When I hit the Command+I keyboard shortcut to italicize text, Brave opens the "search" function—the same one that Command+F opens. Steps to reproduce:

1. Switch system keyboard to Dvorak
2. Highlight editable text (like in an email you're sending)
3. Hit Command+I to attempt to italicize

[bsclifton]

+1 from https://github.com/brave/browser-laptop/issues/13299

Incorrect Cmd-Shift- shortcuts in Dvorak layout in macOS

Description

In macOS, Cmd-Shift-{ and Cmd-Shift-} should be previous tab and next tab, Cmd-Shift-_ and Cmd-Shift-+ should be zoom out and zoom in. Using a US keyboard layout, they are, but with the Dvorak keyboard layout, these specific keys are not remapped.

Oddly, this is only true with Cmd-Shift. For example, Cmd-[ is interpreted as "back" correctly, Cmd-= is correctly interpreted as zoom in, etc.

Steps to Reproduce

1. Set the macOS keyboard layout to "English" > "DV - Dvorak"
2. Open a bunch of tabs in Brave
3. Press the Dvorak key combo Cmd - Shift - } (the } key is on the + = key is a US English keyboard)

Actual result: The content of the current tab is enlarged

Expected result: The next tab is selected.

[bsclifton]

+1 from https://github.com/brave/browser-laptop/issues/7142

Space bar doesn't work in web forum

• Describe the issue you encountered: When I log on to ubuntuforums.org and reply to a post, the spacebar doesn't leave a space when I press it. I need to use Firefox to type replies on that forum.

• Platform (Win7, 8, 10? macOS? Linux distro?): Kubuntu 16.04

• Brave Version (revision SHA):

Brave: 0.13.1 rev: 9dd06f9463d155291efdb419ad0df4c2df16b611 Muon: 2.0.18 libchromiumcontent: 54.0.2840.100 V8: 5.4.500.41 Node.js: 7.0.0 Update Channel: dev os.platform: linux os.release: 4.4.0-62-generic os.arch: x64

• Steps to reproduce:

  1. Set keyboard layout as English (US). Variant: English (Dvorak)
  2. Log on to ubuntuforums.org
  3. Reply to a post.
  4. Type in reply box
  5. Note that as you type, the space bar does not move the cursor.

• Actual result: Note that as you type, the space bar does not move the cursor.

• Expected result: The space bar should make a space appear in my reply.

[bsclifton]

+1 from https://github.com/brave/browser-laptop/issues/7131

Keyboard shortcut override on macOS doesn't work (may be "non-US keyboard layout" related)

Background

macOS 10.12, with all Brave versions I've tested, most recently 0.13.2, rev. 25b1199.

My keyboard is a Swedish hardware layout keyboard, with Dvorak at keyboard layout in macOS.

Most standard shortcuts work fine for me, with a Dvorak layout (like Quit, or Preferences...).

Issue

In macOS it is possible to set application shortcuts for menu items in System Preferences->Keyboard->Shortcuts->App Shortcuts.

Setting a shortcut for "Select Next Tab" and "Select Previous Tab" to Cmd-Shift-] and Cmd-Shift-[ respectively, the expected behaviour in Brave is that these shortcuts should work. Instead, the shortcuts "Zoom in" and "Zoom out", which corresponds to the US keyboard layout (indeed, this is correct behaviour if I switch to US layout and try the same "hardware" shortcut, in both Brave and in Chrome, for instance).

[symulation]

@bsclifton Looks like I should have done some more searching in advance... Thanks for pulling these other issues in.

Additionally, I can report that this isn't a problem in the most recent version of Chromium (not sure exactly how that maps to the version that Brave is running).

[symulation]

I can also report that it is more complicated that just being a complete misalignment of the keys. Some ⌘ key bindings work in MacOS Dvorak Qwerty-⌘ mode and some do not.

For example:

• ⌘V doesn't paste as expected. ⌘. (The "." key on a QWERTY keyboard is the Dvorak equivalent for "V") pastes.
• The "I" key on QWERTY is the "C" key on Dvorak and given the behaviour of ⌘V it might be expected that ⌘I would copy, but it doesn't. ⌘I turns things into italics as MacOS Dvorak Qwerty-⌘ is supposed to work.

[bsclifton]

@symulation can you please try this on our developer channel release? https://brave.com/download-dev

We won't be able to fix this specific issue with our current version of Brave (browser-laptop), so I'm going to close this issue. If the dev channel release above has the issue still, please let me know and I'll help create an issue to track that 😄 Thanks!

[symulation]

@bsclifton , I'm happy to try the developer channel release. Unfortunately the link on the download page ( https://brave-browser-downloads.s3.brave.com/latest/Brave-Browser-Dev.dmg ) provides the following response:

This XML file does not appear to have any style information associated with it. The document tree is shown below.
<Error>
<Code>AccessDenied</Code>
<Message>Access Denied</Message>
<RequestId>031002FAC933E42F</RequestId>
<HostId>
M5vKbVzzN3eA2zNVtnLeMT+IrCxD7vgE1gd+Dvf/S71gAfRM1IGde4iLrQPOsLNMq05J8CgfkdI=
</HostId>
</Error>

[bsclifton]

@symulation can you try again? We had a permissions issue on AWS which we just resolved now 😄

[symulation]

@bsclifton Seems to be fixed.

At least ⌘V no longer behaves like a ⌘Q and now actually cuts text.

When might this version make it into the next stable release?

[bsclifton]

@symulation we're shooting for stable (aka release channel) mid-October (less than a month from now). Before that, we'll have a Beta available which is more stable. But in my experience, the Developer channel has been reliable 😄

[symulation]

Beauty. Thanks. Much appreciated. 😃