Checking for updates doesn't update to brave-core

nirholas commented 6 years ago

I have downloaded Brave on a different computer and noticed the update. On my current browser I am on right now (

Brave	0.25.2
V8	6.9.427.23
Muon	8.1.8
OS Release	17.6.0
Update Channel	Release
OS Architecture	x64
OS Platform	macOS
Node.js	7.9.0
Brave Sync	v1.4.2

and when I click 'Check for updates' nothing happens.

Troubleshooting checklist

There's a good chance the bug you're about to report is fixed in the new version of Brave

Download latest version of Brave from https://brave.com/download/
Import your data by navigating to brave://settings/importData

If you'd like to continue for this old version, please check the applicable items:

[ ] Yes I did try the new version
[ ] I believe this issue is critical for users (security issue, bug that prevents folks from using the software)
[ ] I've read the FAQs and Common Issues section on community.brave.com (https://community.brave.com/c/common-issues)

Description

Steps to Reproduce

1. 2. 3.

What version of Brave are you using?

Using Brave, navigate to about:brave
Under "Version information", you'll see the version (ex: 0.25.2)
Click the clipboard icon to copy the product details and paste here

lorisrossi commented 6 years ago

+1, I saw by chance that there is a new version of Brave (which is a lot better than v0.25.2)

dNifle commented 6 years ago

Same happened to me. Was pretty annoying since Widevine stopped working in the old version. The two browser versions can even be installed in parallel.

bsclifton commented 6 years ago

We will have an upgrade coming soon- if you wanted to follow along, you can see the work here: https://github.com/brave/browser-laptop/pull/15309

nirholas commented 6 years ago

Thank you for looking into this!

brave / browser-laptop