search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 977 forks source link

Return statement exiting early from usage ping call #15331

Closed aekeus closed 5 years ago

aekeus commented 5 years ago

The return statement at https://github.com/brave/browser-laptop/blob/master/app/updater.js#L254 is potentially causing the usage ping to not fire when the referral code confirmation happens.

This requires further investigation, but may be as simple as removing the return statement.

bsclifton commented 5 years ago

@aekeus I don't think we have any more updates planned? Is this something we need fixed? If so, it's going to be complex