Only display upgrade notification (don't perform auto-upgrade) - Githubissues

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave

https://www.brave.com

Other

7.95k stars 977 forks source link

Only display upgrade notification (don't perform auto-upgrade) #15334

Closed bsclifton closed 5 years ago

bsclifton commented 5 years ago

Submitter Checklist:

[ ] Submitted a ticket for my issue if one did not already exist.
[ ] Used Github auto-closing keywords in the commit message.
[ ] Added/updated tests for this change (for new code or code which already has tests).
[x] Ran git rebase -i to squash commits (if needed).
[x] Tagged reviewers and labelled the pull request as needed.
[ ] Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

TBD

Reviewer Checklist:

[ ] Request a security/privacy review as needed if one was not already requested.

Tests

[ ] Adequate test coverage exists to prevent regressions
[ ] Tests should be independent and work correctly when run individually or as a suite ref
[ ] New files have MPL2 license header

diracdeltas commented 5 years ago

two things i mentioned in slack but will note here so that they're not forgotten:

since linux does not have auto-update in the first place, this update should not be shipped on linux
please make sure https://github.com/brave/browser-laptop/pull/15340 is included in this update