search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.94k stars 975 forks source link

Include "Block HTML canvas and WebGL fingerprinting" into Bravery Panel #1876

Closed luixxiul closed 8 years ago

luixxiul commented 8 years ago

Describe the issue you encountered: Sometimes it is hard to detect the issue, when the site does not work as it should, because of blocking the HTML canvas and WebGL fingerprinting. In my case, adding a macro at Zendesk.

Expected behavior: Display a toggle to enable/disable them, next to the "Block phising / malware"

If it is hard to difficult to implement it like this (blocking them needs to be a global config, for example) , something which indicates that they were blocked, like the NoScript icon, would help users to understand what is going on. Currently they have to open devtool and check out the output on the console.

bbondy commented 8 years ago

hah, I was just asking about this same thing! I think ti's a great idea too.

diracdeltas commented 8 years ago

Might be good to reword this as Block advanced fingerprinting methods so it can encompass things like battery status API and audio fingerprinting in the future

diracdeltas commented 8 years ago

CC @bradleyrichter for design: Should there be a number in the bravery panel for # of fingerprinting attempts that were blocked on the page? Similar to #1833

diracdeltas commented 8 years ago

copying my comments from slack re: design issues related to this:

  1. should there be separate switches for canvas/webgl/audio/webrtc/battery/etc fingerprinting? or just one switch for all detectable browser fingerprinting methods? if one switch, there should be a tooltip or something for advanced users to see what methods are being blocked.
  2. should there be a number that shows # of fingerprinting methods blocked? it makes sense but maybe the panel would get too wide.
  3. originally i was going to show a popup notification message for when Site X is potentially trying to fingerprint you via one of these methods, so the user can choose Allow/Deny. this might be redundant now that there is a way to easily see the list of fp methods and easily allow/deny in the Bravery panel. i am leaning against showing these notifications because i think they are somewhat annoying, although Tor Browser does.

IMO the fingerprinting switch should be off-by-default in regular browsing mode and on-by-default for private tabs.

diracdeltas commented 8 years ago

merging into https://github.com/brave/browser-laptop/issues/1951