search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 974 forks source link

PDF rendering fails on Fidelity #2919

Closed stshank closed 6 years ago

stshank commented 8 years ago

Describe the issue you encountered: Clicked the link to a PDF financial statement at Fidelity (https://statements.fidelity.com/). Got error message "invalid or corrupted PDF." More details shows this:

PDF.js v1.5.340 (build: bc86419) Message: Invalid PDF structure

Expected behavior: Views PDF in a new tab. Works in Chrome. When I downloaded the PDF, it opened fine in Adobe Acrobat. Sorry, obviously don't want to attach the file itself.

bbondy commented 8 years ago

I think this is probably fixed in 0.11.2 already but CC @diracdeltas

diracdeltas commented 8 years ago

pretty sure this is fixed in 0.11.2

bbondy commented 8 years ago

Please re-open if it doesn't work in 0.11.2 thanks.

stshank commented 8 years ago

Sorry, just tried with 0.11.2 and got the same problem.

Error message: PDF.js v1.5.364 (build: 81cd66c) Message: Invalid PDF structure

Brave version: Brave: 0.11.2 Electron: 1.3.0 libchromiumcontent: 52.0.2743.82 V8: 5.2.361.43 Node.js: 6.3.0 Update Channel: dev

bbondy commented 8 years ago

could you attach a pdf here?

stshank commented 8 years ago

Sorry, it's a very personal financial statement, so no. If I find other PDFs that break I will, though.

stshank commented 8 years ago

I have a somewhat less private PDF that just failed to render. I'll email it to you.

copiesofcopies commented 8 years ago

I have this same problem regularly with PDFs accessed via federal courts' electronic court filing systems (essentially the other end of PACER). Today, I filed two PDF documents with the court, then attempted to access the filed versions from the court's system. Both of the documents were created the same way -- just exported to PDF from Word. Brave had no problem opening the first, but gave me this error for the second. This suggests to me that the problem may not be a problem with the structure of the PDF.

Unfortunately, because you need to be authenticated to access the documents, I can't post a link. I'm on v.0.11.4 on Windows 10.

diracdeltas commented 8 years ago

do any of the PDFs load if you refresh the page?

bsclifton commented 7 years ago

+1 from support; user is reporting issue with PDFs opened from Xero, an online accounting website. Asking for more info and will share if/when I get those details :smile:

jonathansampson commented 7 years ago

I ran into a similar issue this evening after coming across a Tweet. I found that the PDF link itself directs the user to GitHub when opened in the current tab. When opened in a new tab or window, however, Brave/PDF.js expects the format to be that of a PDF:

Brave/PDF.js Expect Resource to be PDF

image

PDF.js Engaged Only on New Window

brave-bug-pdf-tab-vs-window

rebron commented 6 years ago

Closing. wontfix here but fixed in brave core. I have a Fidelity account and checked a couple of statements. The bigger issue is my statement balance is low, should be way larger ;-)

ianjohnsa commented 5 years ago

I'd like to reopen this since I am experiencing the same issue with a very similar situation. I am running Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit). I have logged into my account with USAA and when trying to view my statement I get the same error message a the top of the PDF plugin for the new window which should open the embedded PDF of the statement: PDF.js v2.0.673 (build: 31012570) Message: Invalid PDF structure.

jonathansampson commented 5 years ago

@ianjohnsa Does the same scenario work in Chrome?

stshank commented 5 years ago

I just tried again on the Fidelity site and also get the "invalid or corrupted PDF file" Version 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit) I have no trouble using Chrome.

On Sat, Oct 27, 2018 at 11:19 AM Sampson notifications@github.com wrote:

@ianjohnsa https://github.com/ianjohnsa Does the same scenario work in Chrome?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/2919#issuecomment-433643587, or mute the thread https://github.com/notifications/unsubscribe-auth/AQDa4zDnAWqiPhhEU8JufjvE6HMEU621ks5upKOWgaJpZM4JcGrz .

bsclifton commented 5 years ago

In the new version of Brave, this should have been fixed with https://github.com/brave/brave-core/pull/967

The issue in the brave-browser repo can be found here: https://github.com/brave/brave-browser/issues/1033

The older version (Muon) won't be receiving the update