search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Dockable developer tools (F12) #3555

Closed Sh1d0w closed 6 years ago

Sh1d0w commented 8 years ago

Did you search for similar issues before submitting this one?

Yes

Describe the issue you encountered:

As a web developer which main browser currently is Brave I find using the developer tools (F12) frequently to inspect the webpage HTML and console output. Currently pressing F12 brings up the developer tools as a separate window. Chrome has option to attach the developer tools to the related window or even the tab you are inspecting. Brave does not have that option, making it pain switching between IDE and the browser window if you want to continiously inspect and observe the opened page.

Expected behavior:

Brave should allow attaching the developer tools (F12) in the relevant tab frame that was inspected.

Chrome:

Brave:

Sh1d0w commented 8 years ago

From electron docs:

https://github.com/electron/electron/blob/master/docs/api/web-contents.md#contentsopendevtoolsoptions

contents.openDevTools([options])

    options Object (optional)
        mode String - Opens the devtools with specified dock state, can be right, bottom, undocked, detach. 
        Defaults to last used dock state. In undocked mode it's possible to dock back. In detach mode it's not.

For some reason it does not work if this option is changed in Brave here:

https://github.com/brave/browser-laptop/blob/master/js/components/frame.js#L450

This feature was introduced here:

https://github.com/electron/electron/issues/5094

I wonder if you guys altered this behaviour in your electron fork?

cc @bbondy @bsclifton

bbondy commented 8 years ago

I'd love to have this too by the way.

Currently upstream hardcodes detach always for webviews. I'm not sure why but I've tried removing that condition and it didn't work. It would be awesome if you figure out why they did that and a fix though.

https://github.com/electron/electron/blob/46b257944113bba1c1258c485757bef421a5e110/atom/browser/api/atom_api_web_contents.cc#L944

Sh1d0w commented 8 years ago

@bbondy Here is the response from the issue I've rised with electron guys:

It is not possible with what we have now, in Chromium the webview is implemented as a 
browser plugin, and the docked devtools is implemented as native view, there is no 
way to mix them up.

Seems like this is not doable unfortunately :(

bbondy commented 8 years ago

It's do-able but they just don't plan to support it. Re-opening.

DidibaDEV commented 8 years ago

This is the only thing preventing me from switching to Brave for good.

lednhatkhanh commented 7 years ago

Please support this! Vivaldi has the same problem tho

getsetbro commented 7 years ago

+1

mrgoos commented 7 years ago

Hi, Any news on that?

rloechner commented 7 years ago

+1

sahas- commented 7 years ago

+1

JoaoFOliveira commented 7 years ago

+1

NikolaiSzabados commented 7 years ago

+1

thynquest commented 7 years ago

That functionnality should be implemented a long time ago ! +1

lekhnath commented 7 years ago

This feature is a must have.

zackeryfretty commented 7 years ago

+1

erangeles commented 7 years ago

Guys, if you want this browser to gain traction enabling developers ease of access is a key. Please please enable this feature.

webhipster commented 7 years ago

+1 Yup, just installed and uninstalling. Come on guys, you can do it! We believe in you!

bbondy commented 7 years ago

this is on our radar and we'll get someone on it as soon as possible.

cndouglas commented 7 years ago

@bbondy Can we assign a closer milestone?

zoh48gz04 commented 7 years ago

Yes, please. This is something really important to many people.

marcelfalliere commented 7 years ago

+1 !

stephband commented 7 years ago

+1

sebastianmacias commented 7 years ago

+1 must have for me

bsclifton commented 7 years ago

Pulling up to 1.0- no promises on a date here, but this issue is 100% on our roadmap 😄

rjdp commented 7 years ago

This is the main reason why most of the web developers and I are unable to switch to brave, I guess the resolution of this issue is fully dependent on authors of electron.

bsclifton commented 7 years ago

@rjdp we have diverged from electron with our Muon project. This is on our radar- @bbondy may be able to provide more details (he's working on detachable tabs right now)

sheixt commented 7 years ago

+1

Great first impression for Brave. As a web developer this feature would be a big influencer on migrating to permanently. Would love an expected milestone date for it ;)

Renbro commented 7 years ago

+1

Can't switch to Brave without this.

nestorjunior commented 7 years ago

Really very important for a migration, I've been using Brave just for a few things ... and not for working.

knzudgt commented 7 years ago

I am just waiting for this feature before switching to Brave, necessary for web development.

Jacalz commented 7 years ago

+1 Really wanting this feature because it is really annoying having it in a separate window 🤔

lednhatkhanh commented 7 years ago

Vivaldi got this feature already

cndouglas commented 7 years ago

+1 from #8716.

ghost commented 7 years ago

+1

samayo commented 7 years ago

I thought this might have been a hidden feature and came here to find a way to attach the console, but I am very amazed this feature doesn't even exist. Many people who work on laptops don't want to switch between the console output and the web page to debug. This is a critical feature.

samayo commented 7 years ago

@lednhatkhanh Vivaldi got this feature already

I just installed and tried Vivaldi based on your comment and the console is detached just like Brave, and there is no way to attach it. Check the image

capture

How were you able to attach the console?

lednhatkhanh commented 7 years ago

Oh, i forgot to mention that you have to download the latest snapshot to use this feature, and it's look exacly the same with chrome dev tools

divyenduz commented 7 years ago

+1

knzudgt commented 7 years ago

Slimjet has already this feature

arobbins commented 7 years ago

Brave Team,

I'm completely onboard with the vision of Brave and love the product you've managed to create thus far. However as a Web Developer I absolutely need this feature to be as productive as I am in Chrome.

I think a major reason why the masses began using Firefox in 2010 was because the majority of developers stood as the vanguard in it's advocacy. Same thing happened during the Chrome migration of ~2012.

IMO Brave needs to appeal to developers for mass adoption to take hold. I'd love to see this feature sooner rather than later.

sebastianmacias commented 7 years ago

@arobbins absolutely agree.

Currently, I can only use brave for web surfing and have to use chrome for dev, I would love to just be able to get rid of chrome once and for all.

Not having the ability to attach the developer tools and not being able to use a few dev extensions such as vuejs-devtools without having to spend hours compiling brave has been a big frustration for me.

I never been as excited about a web browser as I have been with brave, I have tried them all. You have built an amazing product so far but I would definitely be more likely to recommend brave to my peers if you were to implement these missing features and give more attention to the developer community feedback and requests.

vlad-s commented 7 years ago

Attached developer tools and support for Chrome extensions (which is a written goal of the Muon project) is a must for the developers to make the permanent switch to Brave. I'm currently using Brave browser on my phones as day to day, permanent, browser, while using Brave on my laptop (OSX) and desktop (Windows) for regular browsing, development being made on Chrome (with the help of more than 10 extensions, excluding privacy-focused extensions like HTTPs Everywhere, uBlock Origin, WebRTC limiter, Privacy Badger, etc.).

Let us hope that this will be implemented soon enough, or that Muon will put Electron down.

Jacalz commented 7 years ago

+1 from community: https://community.brave.com/t/docked-inspector-other-improvements/3313

samayo commented 7 years ago

Please someone tell me my mouse's right-click btn is broken, because in Developer Tools, I can't seem to right-click on a DOM element like a div either to edit or delete the node. In short, right-click on the HTML elements has no effect inside the developer tools

Jacalz commented 7 years ago

Yeah, I talked with @luke.mulks about this yesterday and it is a bug in Brave 😅 Really needs to get fixed, extremely annoying 😬

rahilwazir commented 7 years ago

@samayo Please do not discuss off topic issue, create new issue for that. Thanks

samayo commented 7 years ago

@rahilwazir Well there are 2.1K issues open, I just wanted to verify it here before I create a new issue. This is far from off topic, I was just being considerate.

cndouglas commented 7 years ago

@samayo No worries! 😉 Right-click in dev tools (issue #6724) is planned to be fixed in 0.18.x.

patrick99e99 commented 7 years ago

+1

jacklorusso commented 7 years ago

+1

I wish I could use Brave all day every day but this is stopping me from using it for work, which is the main time I'm browsing