brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave

https://www.brave.com

Other

7.95k stars 975 forks source link

Ads not disabled in Gmail #3741

Open ShivanKaul opened 8 years ago

ShivanKaul commented 8 years ago

Did you search for similar issues before submitting this one? Yep.

Describe the issue you encountered: Ads in Gmail get displayed. They don't in Chrome with AdBlock installed.

Expected behavior: Ads shouldn't get displayed.

Platform (Win7, 8, 10? macOS? Linux distro?): Mac OS X
Brave Version: 0.11.6
Steps to reproduce:
1. Login to Gmail
2. Click on Social/Promotions tab
Screenshot if needed:

344

bsclifton commented 8 years ago

This is expected behavior (at the moment). The ads themselves are first party; you're on a Google site being served Google ads. However, I know we've discussed blocking first party ads

cc: @bbondy and @BrendanEich, in case you all wanted to respond :smile:

bbondy commented 8 years ago

Would be fixed by cosmetic filters I think. #344

lukemulks commented 7 years ago

FYI - rolling this into the larger webmail client initiative, which will be tracked in #7676