search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Flash support for site X? #386

Closed VikramTiwari closed 8 years ago

VikramTiwari commented 8 years ago

What type of flash support is there in Brave? If none, shouldn't support for PPAPI which is more secure, be there?

Ref: https://support.google.com/chrome/answer/6213033?hl=en

bridiver commented 8 years ago

We currently don't have plans to support Flash, but a "mobile" view that will trigger many sites to display an HTML5 compatible version of the site targeted towards ios is on the roadmap. If there is enough demand we will revisit the decision, but Flash carries a lot of baggage with it even through PPAPI. So far I haven't personally come across anything I really cared about that didn't have a non-flash alternative, but I know there are some out there and at this point it's a question of how many sites/people it affects. I'll leave this issue open to act as a "poll" for now.

diracdeltas commented 8 years ago

+1 for not supporting Flash

bbondy commented 8 years ago

May be added as an option you can explicitly turn on later, but off by default. Preference is to just not support it at all though too.

bagmangood commented 8 years ago

One problem with not supporting flash - a lot of the web still uses flash pretty extensively (portions of YouTube, most streaming sites).

Flash is awful, but unfortunately still necessary at the moment

bridiver commented 8 years ago

Can you provide an example from YouTube?

bagmangood commented 8 years ago

First one I found: https://www.youtube.com/watch?v=qkTzDh8IKNU

bridiver commented 8 years ago

That plays for me on Brave. What do you see on this page https://www.youtube.com/html5 ?

bridiver commented 8 years ago

I do understand your point about Flash and I realize that there are sites that won't work, but some sites are more important than others.

bagmangood commented 8 years ago

I got check marks on everything on the html5 page. Deleted Brave and re-installed (with the latest version from Brave.com) and now the video plays. Guess I should have tried that first.

bridiver commented 8 years ago

Great! We are interested in reports of popular sites that require Flash so please continue to report any that you find and we will try to address them.

bagmangood commented 8 years ago

Created a page on the wiki rather than spam a thread https://github.com/brave/browser-laptop/wiki/Non-Supported-Video-Sites

bridiver commented 8 years ago

Netflix has HTML5 support for Safari, but it does not appear to work on Brave right now. https://github.com/brave/browser-laptop/issues/468

bridiver commented 8 years ago

Not sure about twitch.tv, but anything that plays on mobile Safari should work on Brave at least for SD content (HD has DRM issues) when jwplayer is added

Nhoj1983 commented 8 years ago

So I checked, no hulu, crunchyroll, daisuki, gamespot (video), or funimation available. Mostly geek related sites but seriously going to be hard to make brave my browser if it doesn't support a large amount of what I use the web for which is streaming. I really like brave and I agree flash isn't great but it's kind of needed atm. I realize some sites are more important but I know a lot of people who use at least one of these pretty regularly.

weems commented 8 years ago

Seconding @diracdeltas idea to not support flash, though it could be nice to have some sort of option as users definitely desire to use Brave on sites which only work with flash.

diracdeltas commented 8 years ago

Could anyone who is having trouble with Flash sites like Hulu checkout this branch to see if it fixes the issue: https://github.com/brave/browser-laptop/tree/feature/ua-spoofing

It spoofs the user-agent to iPad (which doesn't run flash by default). Thanks!

bridiver commented 8 years ago

Netflix works on Safari 9+ without any Flash/Silverlight. Might be a better option for ua spoofing because I think Netflix on ios sends you to their app.

bridiver commented 8 years ago

Verified that Netflix sends you to a "get the free app" page for ios

diracdeltas commented 8 years ago

Netflix works on Safari 9+ without any Flash/Silverlight. Might be a better option for ua spoofing because I think Netflix on ios sends you to their app.

I think that is because of EME support. http://techblog.netflix.com/2014/06/html5-video-in-safari-on-os-x-yosemite.html

I'll change it to desktop safari for now

bridiver commented 8 years ago

Hmmm... looks like we may need Widevine then. There is already support in Electron for it and according to http://www.widevine.com there are no licensing fees

FutureSomeOne commented 8 years ago

Twitch.tv !!!!! almost every single gamer go to this site, there will be even more people go to twitch when there is a tournament, if all the gamers (who use computer the most) can't go to their streaming website, they will just switch to other browser

bbondy commented 8 years ago

See https://github.com/brave/browser-laptop/issues/782

weems commented 8 years ago

Prioritization for sites with the most usage will be important as more requests for flash / plugin sites are made. Scaling is going to be important.

Spammie commented 8 years ago

ehm, I wana use spotify website on my laptop but it requires flash what do I do ?

bridiver commented 8 years ago

I don't have a spotify account to test, but there appears to be an html5 version http://blog.72lions.com/projects/2014/12/8/spotify-web-player http://play.spotify.com/

Spammie commented 8 years ago

Well I was in brave and I couldn't access it to listen to some music, it prompts me to download flash ...

JuanJalar commented 8 years ago

Videos on CNET's web pages won't play in Brave, first because of its built in ad blocking, then even when ad blocking is turned off, because they say they need Flash to play. For instance, if you scroll past this CNET article on Brave's mobile release today, http://www.cnet.com/news/brave-software-ad-block-browser-clears-google-hurdle/, you come to a video on Facebook reactions that just won't play. In other instances, CNET says it won't play a video because I have ad blocking on. Then when I turn it off, I get a message that I need to install Flash.

weems commented 8 years ago

Confirmed what @Spammie is experiencing on https://play.spotify.com in Brave 0.7.16

bridiver commented 8 years ago

@Spammie did you try http://play.spotify.com instead of the regular home page? There seems to be a lot of conflicting information and the actual status of an html5 version is unclear

weems commented 8 years ago

There is a <div id="html5audio"></div> tag, but I think the actual authentication / playing of music is negotiated with a flash plugin.

weems commented 8 years ago

It is not HTML5 (pure at least) tries to use the following: https:\/\/play.spotify.edgekey.net\/client\/9cd7401\/flash\/bridge.swf

dscycler commented 8 years ago

cbs.com requires flash.

dscycler commented 8 years ago

Pandora.com requires Flash.

dukrat commented 8 years ago

VMWare vCenter vSphere Web Client requires Flash.

zeg-io commented 8 years ago

Foxnews.com watch live requires flash

dschneiderch commented 8 years ago

http://www.espnfc.us/ seems to require flash although http://espn.go.com/ does not. Version: 0.8.0 Electron: 0.36.8 libchromiumcontent: 47.0.2526.110 Channel: dev

mdkberry commented 8 years ago

cmcmarkets.com.au trading platform needs flash

bbondy commented 8 years ago

This is our plan for Flash: https://github.com/brave/browser-laptop/issues/1093

I'm keeping this open though, retitled as "Flash support for site X?" for now to track the sites we should add to that whitelist.

jetrd001 commented 8 years ago

Twit.tv recomended the Brave browser, so I tried it ... strangly you can watch the recorder potcasts but not the Live stream... this needs Flash .. Bummer .

DivineOmega commented 8 years ago

Excellent idea on restricting Flash use to predetermined white list.

jbshirk commented 8 years ago

+1 for html5 (at least)

osmestad commented 8 years ago

https://listen.tidal.com also requires Flash

bbondy commented 8 years ago

Closing this in favour of this wiki: https://github.com/brave/browser-laptop/wiki/Flash-and-Other-Non-Supported-Plugin-Sites-(Video-and-Non-Video)

And the actual work for this is being done here: https://github.com/brave/browser-laptop/issues/1093

stevenado commented 8 years ago

the next links doesn't work normaly: http://ici.radio-canada.ca the videos doesn't work there cause flash is not activated: http://ici.radio-canada.ca/rdi http://ici.radio-canada.ca/audio-video

http://ici.tou.tv/dans-l-oeil-du-dragon

it's a good idea to not activate flash, but can we get the video link to be able to play it directly with an external tool like vlc or mplayer?

hucekes commented 8 years ago

Amazon Prime Music insists on Flash Brave 0.9.3 Electron 37.7 Windows 10

Copypasty commented 8 years ago

Well... I'm sure there's a very small market, but flash gaming sites don't work.. http://www.kongregate.com/ http://armorgames.com/ http://miniclip.com/games/en/ etc.

3CirclesChurchCommunity commented 8 years ago

Are you kidding? No flash support means Brave is useless to me and many, many others. When I go to Hulu, CBS/ABC/NBC news, or thousands of other sites I CAN'T PLAY A SINGLE VIDEO!!! USELESS!

luixxiul commented 8 years ago

Are you kidding?

I believe 100% that the dev team is not kidding at all, quite serious. And also I believe that there are so many users who are quite serious too. As the comment above (https://github.com/brave/browser-laptop/issues/386#issuecomment-213432518) indicates, if there are suggestions of sites, please add them to the wiki. I lock the conversation.

luixxiul commented 8 years ago

For the participants:

After some discussion on Slack and clarification with Chrome on their Flash plans, here's the latest proposal: https://github.com/brave/browser-laptop/wiki/Flash-Support-Proposal

https://github.com/brave/browser-laptop/issues/1093#issuecomment-224410536