brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 977 forks source link

Manual tests for OS X 0.12.1 RC1 #3999

Closed alexwykoff closed 7 years ago

alexwykoff commented 7 years ago

Installer

  1. [x] Check that installer is close to the size of last release.
  2. [x] Check signature: If OS Run spctl --assess --verbose /Applications/Brave.app/ and make sure it returns accepted. If Windows right click on the installer exe and go to Properies, go to the Digital Signatures tab and double click on the signature. Make sure it says "The digital signature is OK" in the popup window.
  3. [x] Check Brave, electron, and libchromiumcontent version in About and make sure it is EXACTLY as expected.

    Data

  4. [x] Make sure that data from the last version appears in the new version OK.
  5. [x] Test that the previous version's cookies are preserved in the next version.

    About pages

  6. [x] Test that about:bookmarks loads bookmarks
  7. [x] Test that about:downloads loads downloads
  8. [x] Test that about:preferences changing a preference takes effect right away
  9. [x] Test that about:preferences language change takes effect on re-start
  10. [x] Test that about:passwords loads
  11. [x] Test that about:history loads

    Bookmarks

  12. [x] Test that creating a bookmark on the bookmarks toolbar works
  13. [x] Test that creating a bookmark folder on the bookmarks toolbar works
  14. [x] Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
  15. [x] Test that clicking a bookmark in the toolbar loads the bookmark.
  16. [x] Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.

    Context menus

  17. [x] Make sure context menu items in the URL bar work
  18. [x] Make sure context menu items on content work with no selected text.
  19. [x] Make sure context menu items on content work with selected text.
  20. [x] Make sure context menu items on content work inside an editable control (input, textarea, or contenteditable).

    Find on page

  21. [x] Ensure search box is shown with shortcut
  22. [x] Test successful find
  23. [x] Test forward and backward find navigation
  24. [x] Test failed find shows 0 results
  25. [x] Test match case find

    Site hacks

  26. [x] Test https://www.twitch.tv/adobe sub-page loads a video and you can play it

    Downloads

  27. [x] Test downloading a file works and that all actions on the download item works.

    Fullscreen

  28. [x] Test that entering full screen window works View -> Toggle Full Screen. And exit back (Not Esc).
  29. [x] Test that entering HTML5 full screen works. And Esc to go back. (youtube.com)

    Tabs and Pinning

  30. [x] Test that tabs are pinnable
  31. [x] Test that tabs are unpinnable
  32. [x] Test that tabs are draggable to same tabset
  33. [x] Test that tabs are draggable to alternate tabset

    Zoom

  34. [x] Test zoom in / out shortcut works
  35. [x] Test hamburger menu zooms.
  36. [x] Test zoom saved when you close the browser and restore on a single site.
  37. [x] Test zoom saved when you navigate within a single origin site.
  38. [x] Test that navigating to a different origin resets the zoom

    Bravery settings

  39. [x] Check that HTTPS Everywhere works by loading http://www.apple.com
  40. [x] Turning HTTPS Everywhere off and shields off both disable the redirect to https://www.apple.com
  41. [x] Check that ad replacement works on http://slashdot.org
  42. [x] Check that toggling to blocking and allow ads works as expected.
  43. [x] Test that clicking through a cert error in https://badssl.com/ works.
  44. [x] Test that Safe Browsing works (http://excellentmovies.net/)
  45. [x] Turning Safe Browsing off and shields off both disable safe browsing for http://excellentmovies.net/.
  46. [x] Visit https://brianbondy.com/ and then turn on script blocking, nothing should load. Allow it from the script blocking UI in the URL bar and it should work.
  47. [x] Test that about:preferences default Bravery settings take effect on pages with no site settings.
  48. [x] Test that turning on fingerprinting protection in about:preferences shows 3 fingerprints blocked at https://jsfiddle.net/bkf50r8v/13/. Test that turning it off in the Bravery menu shows 0 fingerprints blocked.
  49. [x] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked.
  50. [x] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on.

    Content tests

  51. [x] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Test that context menus work in the new twitter tab.
  52. [x] Load twitter and click on a tweet so the popup div shows. Click to dismiss and repeat with another div. Make sure it shows.
  53. [x] Go to http://www.bennish.net/web-notifications.html and test that clicking on 'Show' pops up a notification asking for permission. Make sure that clicking 'Deny' leads to no notifications being shown.
  54. [x] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password shows up in about:passwords. Then reload https://trac.torproject.org/projects/tor/login and make sure the password is autofilled.
  55. [x] Open a github issue and type some misspellings, make sure they are underlined.
  56. [x] Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text.
  57. [x] Make sure that Command + Click (Control + Click on Windows, Control + Click on Ubuntu) on a link opens a new tab but does NOT switch to it. Click on it and make sure it is already loaded.
  58. [x] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works.
  59. [x] Test that PDF is loaded at http://www.orimi.com/pdf-test.pdf
  60. [x] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run).

    Flash tests

  61. [x] Turn on Flash in about:preferences#security. Test that clicking on 'Install Flash' banner on myspace.com shows a notification to allow Flash and that the banner disappears when 'Allow' is clicked.
  62. [x] Test that flash placeholder appears on http://www.y8.com/games/superfighters

    Autofill tests

  63. [x] Test that autofill works on http://www.roboform.com/filling-test-all-fields

    Per release specialty tests

    Failing or cannot re-produce

    • [ ] If directly-re-entered URL load fails, show the location of the displayed page (#3928)
    • [ ] If directly-entered URL load fails, show the location of the displayed page (#3857)
    • [ ] Can't enable "Web notifications" on twitter webcompat (#3579)
    • [ ] Style ledger notifications like update notifications (#3856)

      In-progress

    • [x] update to https everywhere 5.2.4 security (#3561)
    • [x] Enabling HTTPS Everywhere fails to load suggested items on a product page (#3422)
    • [x] Cicso Webinars not loaded when HTTPS everywhere is enabled (#3838)
    • [x] Enabling HTTPS Everywhere doesn't load iDownloadBlog site properly (#3971)
    • [x] Regression : Flash controls are not working (#3878)
    • [x] Regression: Brave: 0.12.1 - Lastpass doesn't open (#3883)
    • [x] resolve origin vs frameOrigin confusion for permission requests (#3962)
    • [x] Regression : session.setPermissionRequestHandler callback is broken Major (#3877)
    • [x] url temporarily reverts to the current page when entering a new url in the urlbar (#3927)
    • [x] added release notes for 0.12.1 (#3941)
    • [x] Add six new languages to conform to 0.12.2 language plan (#3957)
    • [x] Address bar should be active for about:newtab (#3712)
    • [x] Address bar should be active for about:newtab (#3933)
    • [x] use current version of ledger-* packages... (#3943)
    • [x] password notification bar is not aligned well (#3920)
    • [x] misc ui fixes (#3940)
    • [x] Address bar should be active for about:newtab (#3933)
    • [x] Regression: noscript icon is misaligned in title mode (#3931)
    • [x] Regression : session.setPermissionRequestHandler callback is broken (#3877)
    • [x] url temporarily reverts to the current page when entering a new url in the urlbar (#3927)
    • [x] Add read-only about:extensions page (#3926)
    • [x] password notification bar is not aligned well design (#3920)
    • [x] Autocomplete pulldown on twitter log in dialog autofill (#3915)
    • [x] Button icons are style-wonked. Must fix. bug design Major (#3917)
    • [x] display different payment options based on user location (#3862)
    • [x] Regression : Flash plugin not loading after authorized to run (#3906)
    • [x] Regression : Spell check is missing (#3904)
    • [x] 1Password is not filling the form and Brave is saving the password (#3897)
    • [x] Regression: Brave: 0.12.1 - Lastpass doesn't open (#3883)
    • [x] detect Brave Payments user location and display different dialog content (#3711)
    • [x] Regression : Flash controls are not working (#3878)
    • [x] If directly-re-entered URL load fails, show the location of the displayed page (#3928)
    • [x] Regression : session.setPermissionRequestHandler callback is broken (#3877)
    • [x] url temporarily reverts to the current page when entering a new url in the urlbar (#3927)
    • [x] Add read-only about:extensions page (#3926)
    • [x] password notification bar is not aligned well (#3920)
    • [x] Autocomplete pulldown on twitter log in dialog autofill (#3915)
    • [x] Button icons are style-wonked. Must fix. (#3917)
    • [x] display different payment options based on user location (#3862)
    • [x] Regression : Flash plugin not loading after authorized to run (#3906)
    • [x] Regression : Spell check is missing (#3904)
    • [x] 1Password is not filling the form and Brave is saving the password (#3897)
    • [x] Regression: Brave: 0.12.1 - Lastpass doesn't open (#3883)
    • [x] detect Brave Payments user location and display different dialog content (#3711)
    • [x] Regression : Flash controls are not working (#3878)
    • [x] Primary button has wrong top and bottom border (#3923)
    • [x] New 'Add Funds...' dialog is cropped at low resolution (#3879)
    • [x] Brave crashes when Dashlane password manager is selected crash (#3909)
    • [x] Brave wallet address text is not properly aligned when Transfer BTC button is enabled (#3910)
    • [x] Brave wallet address text is not properly aligned (#3916)
    • [x] Extra separator in the about:downloads right click context menu (#3908)
    • [x] New Tab context menu not needed options (#3670)
    • [x] Regression : Autofill modals do not open (#3903)
    • [x] Right click to search should respect session setting of current tab (#3662)
    • [x] Context menu search respects session setting of current tab (#3895)
    • [x] extension actions (#3867)
    • [x] extensions are missing browser/page action icons (#2224)
    • [x] Lastpass Create account shows blank page when LastPass enabled in Preferences password-manager (#2936)
    • [x] bitcoin wallet address overflows on some screen resolutions (#3629)
    • [ ] clipboard icon on add funds popover probably needs to be moved (#3484)
    • [x] new dialog design for adding funds (#3803)
    • [x] New (and much improved) layout for Add funds... dialog (#3677)
    • [x] Fix localization sorting (#3855)
    • [x] Harmonize publisher visits (#3852)
    • [x] a publisher should get a visit increment only on a new tab... (#3830)
    • [x] Renderer crash after signing in https://*.slack.com/home (#3841)
    • [x] Add Malay (Malaysia) language (#3843)
    • [x] whitelisted mixed content pages incorrectly showing as secure in private browsing mode (#3793)
    • [x] Re-block running insecure content (#3808)
    • [x] mixed content site setting from private mode should not apply in regular browsing mode (#3795)
    • [x] Mixed-content lock control should be able to re-lock and reload the page like Firefox. (#3770)
    • [ ] add notification event 24h prior to reconcilation (#3828)
    • [ ] Add notification under status message to inform user of their contribution day (#3801)
    • [x] In payments status, show next contribution date (#3833)
    • [x] make use of ledger-geoid and the /v1/exchange/providers endpoint (#3831)
    • [x] Bitcoin exchange extravaganza (#3824)
    • [x] Mac menubar is inaccessible while download is in progress bug (#3823)
    • [x] add something to the UI to inform ledger.js when the user closes the 'add funds' popover enhancement (#3612)
    • [x] Clear Autofill option in the Clear browsing data modal autofill (#3458)
    • [x] Address bar should be active for about:newtab (#3712)
    • [x] Address bar is not "active" when it should be (#3718)
    • [x] only update the menu when bookmarks or closed tabs change (#3813)
    • [x] Cmd+T (New Tab) shortcut becomes disabled while navigation occurs (#3782)
    • [x] Change TM symbol to (R) symbol for password managers in preferences (#3809)
    • [x] Balance of bitcoin can show a scary 0 value when no connection (#3785)
    • [x] Feeling of panic immidiately on every start (#3778)
    • [x] Improve UX of unavailable ledger balance (#3805)
    • [x] Tell me what your favorite color is on Slack (#3010)
    • [x] Follow-up of clock. improves #3767 (#3796)
    • [x] Closed frames shouldn't include newtab (#3804)
    • [x] Closed frames shouldn't include newtab (#3258)
    • [x] Show favicons applied on bookmark folders along with bookmarked items. (#3622)
    • [x] Random: ledger balance error: "Error: HTTP response 401 for GET /api/balance" (#3736)
    • [x] memory pressure crash crash (#3775)
    • [x] remove mutation observers from brave content scripts (#3773)
    • [x] Disabling Payments doesn't retain states (#3612)
    • [x] Ledger timer not starting when changing focus to tabs opened in the background (#3716)
    • [x] add newTab page state (#3765)
    • [x] Add clock component (#3767)
    • [x] UI tweak: Insecure dialog has some white on the right (#3708)
    • [x] Dismiss context menu when pressing tab and esc (#3739)
    • [x] Give more meaningful name to siteUtils method (#3640)
    • [x] Change '...' to Unicode ellipsis (#3675)

      Ledger

  64. [x] Create a wallet with a value other than $5 selected in the monthly budget dropdown. Click on the 'Add Funds' button and check that Coinbase transactions are blocked.
  65. [x] Remove all ledger-*.json files from ~/Library/Application\ Support/Brave/. Go to the Payments tab in about:preferences, enable payments, click on create wallet. Check that the add funds button appears after a wallet is created.
  66. [ ] Click on add funds and verify that adding funds through Coinbase increases the account balance.
  67. [ ] Repeat the step above but add funds by scanning the QR code in a mobile bitcoin app instead of through Coinbase.
  68. [x] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table.
  69. [x] Go to https://jsfiddle.net/LnwtLckc/5/ and click the register button. In the Payments tab, click add funds. Verify that the transfer funds button is visible and that clicking on transfer funds opens a jsfiddle URL in a new tab.
  70. [x] Go to https://jsfiddle.net/LnwtLckc/5/ and click unregister. Verify that the transfer funds button no longer appears in the add funds modal.
  71. [x] Check that disabling payments and enabling them again does not lose state.

    Session storage

Do not forget to make a backup of your entire ~/Library/Application\ Support/Brave folder.

  1. [x] Temporarily move away your ~/Library/Application\ Support/Brave/session-store-1 and test that clean session storage works. (%appdata%\Brave in Windows, ./config/brave in Ubuntu)
  2. [x] Test that windows and tabs restore when closed, including active tab.
  3. [x] Move away your entire ~/Library/Application\ Support/Brave folder (%appdata%\Brave in Windows, ./config/brave in Ubuntu)

    Cookie and Cache

  4. [x] Make a backup of your profile, turn on all clearing in preferences and shut down. Make sure when you bring the browser back up everything is gone that is specified.
  5. [x] Go to http://samy.pl/evercookie/ and set an evercookie. Check that going to prefs, clearing site data and cache, and going back to the Evercookie site does not remember the old evercookie value.

    Update tests

  6. [ ] Test that updating using BRAVE_UPDATE_VERSION=0.8.3 env variable works correctly.
aekeus commented 7 years ago

3579 not working as expected

screen shot 2016-09-14 at 3 28 31 pm
aekeus commented 7 years ago

Note - removing platform specific specialty items that are not osx related

aekeus commented 7 years ago

Payment modal styling issues:

screen shot 2016-09-14 at 6 21 20 pm
aekeus commented 7 years ago

I did not see the payments notification bar as specified in #3828 - but I did see the payments button and dialog.

aekeus commented 7 years ago

Not testing #3824 per #3831 comment