search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Mouse scrolling wheel issues #4472

Closed mpdonnelly closed 8 years ago

mpdonnelly commented 8 years ago

Did you search for similar issues before submitting this one?

Describe the issue you encountered: When opening a link which causes a new tab to be opened, your scrolling behavior can be broken

Reported behaviors include:

Work around:

Expected behavior: You should be able to scroll

silverslimer commented 8 years ago

I can confirm that scrolling is functioning poorly. When I use it, it scrolls all the way to the bottom regardless of how slightly I slid the wheel.

csolve commented 8 years ago

Scrolling inoperative on some websites. Scroll wheel doesn't function, and scroll bar on right side of browser just flashes and sometimes will scroll down the page.

Followed a link to https://www.yahoo.com/ and cannot navigate with scroll wheel or browser bar.

AaronLenoir commented 8 years ago

Since 0.12.3 having the same behavior on windows 10. Scrolling either puts the page at the top or at the bottom, or it does nothing sometimes.

In my case, it only seems to happen when I click through from links on twitter.com (which is currently a pinned tab, but unpinning doesn't change the behavior). Clicking through to a link on this page, for example, doesn't produce the behaviour.

On the pages where it happens, if I click through to a link using ctrl + click (open in new tab) the issue is not there in the new tab. But if I open the link in the same tab the issue is still there.

Also, when I manually paste the address in a new tab, it doesn't occur either.

SlavikCA commented 8 years ago

Not sure, if related.

What I found, if when I open 1st site (I open https://news.google.com/) And then click on the link (any news article), which opens in new tab - then I can't scroll the page in that new tab - not with mouse, not with PgUp, PgDown:

However, if I copy the page URL and reopen page myself - scrolling is working

privatzee commented 8 years ago

I had the same scrolling problem today on a github page. The problem was confined to only that one tab. I pasted the URL into a new tab and that tab/page worked fine. (Win7 x64)

I'm pretty sure it was this page: https://help.github.com/articles/searching-issues/

Edit: Here's another bad-scrolling report: #4285

@bbondy mystery unveiled: the scrolling problem seems to occur with any link that has a target attribute.

Kzeir commented 8 years ago

Me too: One of the Web Pages is this http://www.gearbest.com/cell-phones/pp_363558.html..

ghost commented 8 years ago

Issue seems to occur following an outbound link that opens a new tab with either left click or mouse wheel click. As far as I can tell, pages that do not open a new tab when left clicked do not have issues, even when opened with mouse wheel click.

Opening with right click & "Open Link in New Tab" does not have issues. Neither does copy-pasting link address .

admiral142 commented 8 years ago

I've had scrolling issues since the latest update as well.

bsclifton commented 8 years ago

Hey there folks! I'm digging into this issue and hope to find the root cause

I was easily able to reproduce on Windows 10

bsclifton commented 8 years ago

If you're having this problem on Windows, give this post a big thumbs up

(click the thumbs up below)

bsclifton commented 8 years ago

If you're having this problem on a Mac or Linux, give THIS post a thumbs up

(you should not be seeing it- the only thumbs up was from me)

bsclifton commented 8 years ago

@admiral142 @KVtemp @Kzeir @SlavikCA @mpdonnelly @privatzee @AaronLenoir and others- what platform are you all on? Windows? Mac?

bsclifton commented 8 years ago

Looks to be isolated to 0.12.3 on Windows

Root cause (at this time) appears to be related to the Electron or Chromium upgrade we did as part of the release

Folks that reported the issue (before fully characterizing it) @Consoledotlog - Windows 10 64bit post Anniversary Update @Miguelcldn - Windows 10 @privatzee - Win7 x64 @raggmann - Win10 32

Twitter reports: Win7 - https://twitter.com/grootstok/status/783467368177467392

privatzee commented 8 years ago

I've got Win7 x64, as stated above. It happens anywhere that I tested with a tab opened via a target attribute in a link.

bsclifton commented 8 years ago

@privatzee thanks! and I believe your guess above is correct; problem seems to be related to target=_blank (haven't proven it yet, but it seems consistent)

Kzeir commented 8 years ago

I've windows 10 64bit Anniversary Update too..

Att: Alessandro Tetsuo More

2016-10-04 22:04 GMT-03:00 Brian Clifton notifications@github.com:

@privatzee https://github.com/privatzee thanks! and I believe you're correct, it seems to be related to target=_blank (I haven't proven it yet, but it seems consistent)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/4472#issuecomment-251556535, or mute the thread https://github.com/notifications/unsubscribe-auth/AQvmEoZ4fbwM75W03pHM5CcQSvItHavmks5qwveLgaJpZM4KM1oD .

bridiver commented 8 years ago

the problem does appear to be restricted to renderer initiated new tabs which would include things like targets and window.open

texandirt88 commented 8 years ago

One website is http://breitbart.com on windows 10 platform.

bsclifton commented 8 years ago

Great news folks! A work-around has been found :tada:

Our developer @bridiver dug deep into the Chromium code and found that this issue was likely introduced in our upgrade to Chromium 53.0.2785.116. Specifically, the problem is related to functionality introduced by this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=613414

We're working through the remaining issues and hope to have a new release soon. Please bear with us as we finish up testing- we want to make sure we're offering everybody a solid fix and not something which fixes this but introduces other issues.

Thanks! :smile:

bsclifton commented 8 years ago

And the new version of Brave with the fix is live! Thanks for being patient, folks! Let us know how this new version looks :smile:

bbondy commented 8 years ago

0.12.4 fixes this problem and is available now. Thanks for your patience!

privatzee commented 8 years ago

Works fine now in Brave 0.12.4 Win7 x64 Thanks @bsclifton, for having posted the explanation as to why it happened.