search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Manual tests for OS X 0.12.4 RC1 #4609

Closed alexwykoff closed 7 years ago

alexwykoff commented 7 years ago

Installer

  1. [x] Check that installer is close to the size of last release.
  2. [x] Check signature: If OS Run spctl --assess --verbose /Applications/Brave.app/ and make sure it returns accepted. If Windows right click on the installer exe and go to Properties, go to the Digital Signatures tab and double click on the signature. Make sure it says "The digital signature is OK" in the popup window.
  3. [x] Check Brave, electron, and libchromiumcontent version in About and make sure it is EXACTLY as expected.

    Per release specialty tests

    • [x] titlebar disappears if the list in the autocomplete pulldown scrolled to the bottom (#4539)
    • [x] Increase interval for content script checks (#4558)
    • [x] Add addSite with list to rebuild (#4590)
    • N/A Fix overflow for URL autocomplete on Windows (#4582)
    • [x] Bookmark suggestions makes it impossible to type the URL (#4581)
    • [x] New tab doesn't record the first typed character in a new tab (#4583)
    • [x] The urlbar is really touchy and forcing errors (#4584)
    • [x] Urlbar Optimization Problems Tracking issues (#4585)
    • [x] Show bookmarks toolbar automatically if it was disabled after importing bookmarks successfully (#4587)
    • [x] Show bookmarks toolbar after data import (#4507)
    • [x] Opening new tab retains the previous active tab's URL regression security (#4580)
    • [x] When importing on a clean install, it appears as though nothing has happened (#4586)
    • [x] Unable to select text on a page opened in a new tab following a link (#4517)
    • [x] Link hover indicators flicker when moving the cursor across links on tabs opened from links (#4518)
    • [x] scrolling on mouse not working - when I try to use mouse scroll wheel it doesn't work (#4472)
    • [x] urlbar autocomplete suffix causing issues (#4573)
    • [x] ESPN video player doesn't work (#4572)
    • [x] Potential fix for URL bar lag. (#4563)
    • [x] typing in urlbar fast still can be laggy (#4360)
    • N/A Stop recreating shortcut on my desktop after every update installation (#1181)
    • [x] Support Request : Put system details and Brave version in the subject line of the support email (#4542)
    • [x] Update Favicons doesnt work as expected (#4339)
    • [x] added release notes for 0.12.4 (#4550)
    • N/A Close buttons on Windows are not center aligned (#4512)
    • N/A Caption Buttons Alignment, Icons Broken (#4364)
    • N/A Redid caption buttons for Windows 10 using SVG (#4560)
    • [x] Add search query conditions (#4557)
    • [x] Search via URL bar doesn't work when ending with a dot (#4546)
    • [x] Findbar lags sometimes losing characters (#3876)
    • [x] Stop loading button shows as "Reload page" (#4548)
    • [ ] Brave payments: Line should always appear when user scroll down (#3888)
    • N/A Refresh buttons is not aligned with Home button (#4513)
    • [x] s/next payment submission/next payment contribution/ in payment history modal (#4521)
    • [x] change submission to contribution (#4528)
    • N/A Remove border radius from Windows 7; it has issues on higher DPI setups. (#4524)
    • [ ] Regression: Brave Payments : Ledger headers should not disappear while scrolling. (#4461)
    • [x] Brave payments wrong contribution date (#4058)
    • [x] reset reconciliation time when publisher window is closed (#4516)
    • [x] handle getBraveryProperties error (#4514)
    • [x] Brave Payments : First time user wallet creation : If a user attempts to change the value before the wallet is created, Brave will crash. (#4421)
    • [x] Brave doesn't remember last position and size if you set it to start with homepage (#3754)
    • [x] Help -> Submit Feedback is not opening the mail client for certain users (#4487)
    • [x] Saved site exceptions needs padding from Manage adblock settings (#4503)
    • [x] Style needs update on preferences > search (#4493)
    • [x] History columns have style issues (#4492)
    • [ ] Brave 0.12.2dev-RC4 crash when closing a tab crash (#4290)
    • [ ] Brave crashes when tabs are pinned(Intermittent issues) (#3760)
    • [ ] history list shows unnecessary duplicates for same-page actions (like google maps) (#3848)
    • [x] Support regional adblock files (#1357)
    • [x] Regional adblock (#4489)
    • [ ] Brave payments: Line should always appear when user scroll down (#4395)
    • N/A Polished up full screen detection logic (Windows only) (#4463)
    • N/A Caption buttons inconsistency (#4416)
    • [x] Minor toolbar visual refinement suggestions (#4400)
    • [ ] Generating and filling bookmark folders should cause the bookmark menu to rebuild (#3968)
    • [x] Update menu.js to rebuild when handling (add/remove) bookmark folders (#4390)
    • [x] Bookmarks menu not updated when adding/removing bookmark folder (#4227)
    • [x] Use png_data for favicon of bookmarks imported from HTML (#4345)
    • [x] Defer setAutofill*Detail to frame.js (#4357)
    • [x] Autofill Modal doesn't show when about:autofill opened from about:about (#4350)
    • N/A Adds rounded borders to the top corners for Windows 7 (#4342)
    • N/A Windows 7 - window corners need border radius (#4216)
    • [x] remove the word visit for non-us bitcoin links (#4333)
    • [x] Move the word visit inside the payments button (#4212)
    • [x] Missing "Bookmark This Link" context menu item for selected text link (#3807)
    • [x] Allow per site Bravery settings in private tabs (#1824)
    • [x] Private tab preferences (#4468)
    • [x] Window size is not restored correctly. (#4385)
    • [x] Save the window size (width, height) and use it when restoring from s… (#4482)
    • [x] about:history enhancements (#4488)
    • [x] refine styles in about:history to look more like mockup (#4072)
    • [x] History entries are not properly aligned (#3996)
    • [x] SitePermissionsPage needs a 'clear all' button (#4134)
    • [x] Add an option to clear saved site exception in clear browsing data dialog (#4174)
    • [x] Add setting observer (#4452)
    • [x] Add tests for Ledger export utilities (and fix bugs) (rebased #4429) (#4436)
    • [x] Flash content not loaded in Private window (#3998)
    • [x] noscript and flash site settings should not be shared from private browsing into regular browsing (#3835)
    • [x] restore noscript 'allow once' functionality (#2745)
    • [x] Localization issue: US date format is confusing to everyone (#4294)
    • [x] Small adjustments to Payment History modal and CSV files (#4332)
    • [x] Use the latest version of ledger-* packages (#4340)

      Ledger

  4. [ ] Create a wallet with a value other than $5 selected in the monthly budget dropdown. Click on the 'Add Funds' button and check that Coinbase transactions are blocked.
  5. [ ] Remove all ledger-*.json files from ~/Library/Application\ Support/Brave/. Go to the Payments tab in about:preferences, enable payments, click on create wallet. Check that the add funds button appears after a wallet is created.
  6. [ ] Click on add funds and verify that adding funds through Coinbase increases the account balance.
  7. [ ] Repeat the step above but add funds by scanning the QR code in a mobile bitcoin app instead of through Coinbase.
  8. [x] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table.
  9. [x] Go to https://jsfiddle.net/LnwtLckc/5/ and click the register button. In the Payments tab, click add funds. Verify that the transfer funds button is visible and that clicking on transfer funds opens a jsfiddle URL in a new tab.
  10. [x] Go to https://jsfiddle.net/LnwtLckc/5/ and click unregister. Verify that the transfer funds button no longer appears in the add funds modal.
  11. [x] Check that disabling payments and enabling them again does not lose state.

    Data

  12. [x] Make sure that data from the last version appears in the new version OK.
  13. [x] Test that the previous version's cookies are preserved in the next version.

    About pages

  14. [x] Test that about:adblock loads
  15. [x] Test that about:autofill loads
  16. [x] Test that about:bookmarks loads bookmarks
  17. [x] Test that about:downloads loads downloads
  18. [x] Test that about:extensions loads
  19. [x] Test that about:history loads history
  20. [x] Test that about:passwords loads
  21. [x] Test that about:preferences changing a preference takes effect right away
  22. [x] Test that about:preferences language change takes effect on re-start

    Bookmarks

  23. [x] Test that creating a bookmark on the bookmarks toolbar works
  24. [x] Test that creating a bookmark folder on the bookmarks toolbar works
  25. [x] Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
  26. [x] Test that clicking a bookmark in the toolbar loads the bookmark.
  27. [x] Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.

    Context menus

  28. [x] Make sure context menu items in the URL bar work
  29. [x] Make sure context menu items on content work with no selected text.
  30. [x] Make sure context menu items on content work with selected text.
  31. [x] Make sure context menu items on content work inside an editable control (input, textarea, or contenteditable).

    Find on page

  32. [x] Ensure search box is shown with shortcut
  33. [x] Test successful find
  34. [x] Test forward and backward find navigation
  35. [x] Test failed find shows 0 results
  36. [x] Test match case find

    Geolocation

  37. [x] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works

    Site hacks

  38. [x] Test https://www.twitch.tv/adobe sub-page loads a video and you can play it

    Downloads

  39. [x] Test downloading a file works and that all actions on the download item works.

    Fullscreen

  40. [x] Test that entering full screen window works View -> Toggle Full Screen. And exit back (Not Esc).
  41. [x] Test that entering HTML5 full screen works. And Esc to go back. (youtube.com)

    Tabs and Pinning

  42. [x] Test that tabs are pinnable
  43. [x] Test that tabs are unpinnable
  44. [x] Test that tabs are draggable to same tabset
  45. [x] Test that tabs are draggable to alternate tabset

    Zoom

  46. [x] Test zoom in / out shortcut works
  47. [x] Test hamburger menu zooms.
  48. [x] Test zoom saved when you close the browser and restore on a single site.
  49. [x] Test zoom saved when you navigate within a single origin site.
  50. [x] Test that navigating to a different origin resets the zoom

    Bravery settings

  51. [x] Check that HTTPS Everywhere works by loading http://www.apple.com
  52. [x] Turning HTTPS Everywhere off and shields off both disable the redirect to https://www.apple.com
  53. [x] Check that ad replacement works on http://slashdot.org
  54. [x] Check that toggling to blocking and allow ads works as expected.
  55. [x] Test that clicking through a cert error in https://badssl.com/ works.
  56. [x] Test that Safe Browsing works (http://excellentmovies.net/)
  57. [x] Turning Safe Browsing off and shields off both disable safe browsing for http://excellentmovies.net/.
  58. [x] Visit https://brianbondy.com/ and then turn on script blocking, nothing should load. Allow it from the script blocking UI in the URL bar and it should work.
  59. [x] Test that about:preferences default Bravery settings take effect on pages with no site settings.
  60. [x] Test that turning on fingerprinting protection in about:preferences shows 3 fingerprints blocked at https://jsfiddle.net/bkf50r8v/13/. Test that turning it off in the Bravery menu shows 0 fingerprints blocked.
  61. [x] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked.
  62. [x] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on.

    Content tests

  63. [x] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Test that context menus work in the new twitter tab.
  64. [x] Load twitter and click on a tweet so the popup div shows. Click to dismiss and repeat with another div. Make sure it shows.
  65. [x] Go to http://www.bennish.net/web-notifications.html and test that clicking on 'Show' pops up a notification asking for permission. Make sure that clicking 'Deny' leads to no notifications being shown.
  66. [x] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password shows up in about:passwords. Then reload https://trac.torproject.org/projects/tor/login and make sure the password is autofilled.
  67. [x] Open a github issue and type some misspellings, make sure they are underlined.
  68. [x] Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text.
  69. [x] Make sure that Command + Click (Control + Click on Windows, Control + Click on Ubuntu) on a link opens a new tab but does NOT switch to it. Click on it and make sure it is already loaded.
  70. [x] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works.
  71. [x] Test that PDF is loaded at http://www.orimi.com/pdf-test.pdf
  72. [x] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run).

    Flash tests

  73. [x] Turn on Flash in about:preferences#security. Test that clicking on 'Install Flash' banner on myspace.com shows a notification to allow Flash and that the banner disappears when 'Allow' is clicked.
  74. [x] Test that flash placeholder appears on http://www.y8.com/games/superfighters

    Autofill tests

  75. [x] Test that autofill works on http://www.roboform.com/filling-test-all-fields

    Session storage

Do not forget to make a backup of your entire ~/Library/Application\ Support/Brave folder.

  1. [x] Temporarily move away your ~/Library/Application\ Support/Brave/session-store-1 and test that clean session storage works. (%appdata%\Brave in Windows, ./config/brave in Ubuntu)
  2. [x] Test that windows and tabs restore when closed, including active tab.
  3. [x] Move away your entire ~/Library/Application\ Support/Brave folder (%appdata%\Brave in Windows, ./config/brave in Ubuntu)

    Cookie and Cache

  4. [x] Make a backup of your profile, turn on all clearing in preferences and shut down. Make sure when you bring the browser back up everything is gone that is specified.
  5. [x] Go to http://samy.pl/evercookie/ and set an evercookie. Check that going to prefs, clearing site data and cache, and going back to the Evercookie site does not remember the old evercookie value.

    Update tests

  6. [x] Test that updating using BRAVE_UPDATE_VERSION=0.8.3 env variable works correctly.
aekeus commented 7 years ago

Toolbar often is not controllable via menu:

screen shot 2016-10-07 at 2 15 52 pm

https://github.com/brave/browser-laptop/pull/4587 Failed https://github.com/brave/browser-laptop/issues/4507 Failed

bbondy commented 7 years ago

@aekeus for #4587 it should only show if you have 0 bookmarks then improt

aekeus commented 7 years ago

I see. Thanks. The other issue remains, the toolbar button shown/hidden status becomes inconsistent with the menu bar check.

aekeus commented 7 years ago

3968 not working as expected. In the screenshot below the third level bookmark folder is not showing its two sites in the menu.

screen shot 2016-10-07 at 3 53 18 pm