search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Make a notification banner when fingerprinting is on for certain sites and is known to break them #4621

Open bbondy opened 8 years ago

bbondy commented 8 years ago

We should warn the user that this site has known problems when fingerprinting is enabled. With an option to disable now.

cc @luixxiul @diracdeltas

luixxiul commented 8 years ago

that's what exactly I was going to propose :-)

srirambv commented 8 years ago

similar to #3723?

luixxiul commented 8 years ago

Sometimes it would be hard to put a placeholder on a broken page like google sheet. #2343

@bsclifton has created an issue for this here -> #2965

bbondy commented 8 years ago

ya I think we came to that same conclusion in that ticket but I'll leave this one open instead.

diracdeltas commented 8 years ago

should this be a whitelist or just a notification that appears whenever a site is trying to access fingerprinting APIs (canvas, webgl, audio, etc.) in a first-party context? i am leaning toward the latter because maintaining the whitelist will be a lot of work.

bbondy commented 8 years ago

if you can get the generic way to work that'd be even better ya.

bbondy commented 8 years ago

I guess it depends on how common we have fingerprinting stats show up. If it's not very common the generic way is probably better.