YouTube showing ads

[bsclifton]

Did you search for similar issues before submitting this one? Yes

Describe the issue you encountered: Reported via support:

I’ve been trialing Brave for the last day or so. I was enjoying no ads on youtube until about the 3rd or 4th clip, then straight up I started getting ads. How do I fix this? The ad blocker is switched on in settings.

I tried some of the video links provided and was unable to reproduce. Maybe related to

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
• Brave Version:
• Screenshot if needed:
• Any related issues:

[reesinkf]

@lukemulks yep, still getting ads, just got 2 in a row.

[lukemulks]

Thanks for the confirmation @reesinkf Going to see if we can reproduce for each set of conditions reported here.

[JamieHitGub]

they are both off for me

[JamieHitGub]

Tried clearing again with the following and then re-opened browser and now I can't make an ad appear, maybe before I didn't properly clear cookies or something, it was pretty late here. These are the options that seemed to fix it for me on version 0.13.

[JamieHitGub]

Ok this is interesting, logged into youtube so I could sub to channels/check my watchlists. Now adverts are back. If I log out they dissapear.

Edit: I can re-create this constantly, when logged out - no adverts, when logged in, adverts every time. I recorded my screen as an example if needed. The video I randomly clicked on and used for this test is this one. https://www.youtube.com/watch?v=pd7uo2BVjOA

Hope this helps.

[lukemulks]

thanks @JamieHitGub the info was helpful.

@reesinkf @echosa @JamieHitGub we just pushed v0.13.1. Can you try updating to v0.13.1, clearing cache/cookies and attempt to reproduce?

If that doesn't work, can you try backing up your bookmarks and brave wallets (if payments are enabled in your browser), uninstall and attempt a fresh Brave install?

[echosa]

First video I tried played without ad. The second video played an ad first. The only difference I can tell: I was logged in to Google/YouTube for the second. I updated and cleared everything here, restarting the browser when prompted:

I have not tried completely uninstalling/reinstalling the browser. I'll do that when I get a chance.

Additional screenshots:

[echosa]

Ok, I just completely* (in theory... see below) uninstalled Brave and reinstalled it from a fresh download from the website. I used the same video as shown in my previous comment. I first viewed it logged out. No ad. I then logged into Google (required setting up LastPass), and opened the same video again. I got an ad. Definitely seems related to being logged into Google. I didn't do anything else. No settings changes (everything is back to default: colored tabs, hovering over tabs previews it, etc. all stuff I'd previously turned off), all my stats show on newtab were back to zero (sad day), etc.

• When I say "completely (in theory)", one thing concerns me. When I went to set up LastPass, it remembered my email address. I had told it to remember email, so normally that's expected, but having "completely" uninstalled, I would have expected that information to not be there. :-/

Also, considering I'm on OS X, I should explain the uninstall process. I used an app called AppCleaner (version 3.4, the latest, available here: http://freemacsoft.net/appcleaner/) which lets you pick an app, and it detects matching/related files in your preferences, temp directories, etc. and of course the .app itself. I deleted every matching file and folder it found, then emptied the trash, just to be sure.

[lukemulks]

This is incredibly helpful information @echosa.

Also, apologies about the stats-loss, but know that the sacrifice has helped us narrow in on this (I had to do the same thing last week too, was a bummer)

I suspect that the issue is directly tied with authentication, given that Google uses YouTube for authentication for both Doubleclick (Google's primary ad server) and YouTube.

Going to work with our team on reproducing against the specific conditions you just mentioned, and will follow up. Thanks again, really appreciate your help with this.

[srirambv]

I see Ads on YouTube after I login to YouTube. This is on the first video which was played after logging into YouTube

[JamieHitGub]

I cleared all cookies/history etc then removed app via the 'drag to bin' method on the mac. Manually checked for other files and removed them too. Re-installed from a fresh download. Still adverts only when logged in.

[pixelass]

@srirambv I can reproduce your report. I can also see ads (when signed in)

I always clear data when I close the browser but also did a manual clearing.

[lukemulks]

Thanks all, one more thing I could use some data/tests on here.

While logged into Google, can you go to the two ads settings pages (control ads in Google, control ads while outside of google, Google search ads) and:

1. Let me know if the settings are on or off for all 3 switches.

2. If on, can you try turning off for all 3, signing out, signing in and attempt to reproduce?

https://www.google.com/settings/u/0/ads/authenticated?hl=en

I just noticed all of mine are set to off, and didn't consider that this may impact what we are seeing here since authentication is required for these settings to work.

Thanks again!

On Feb 1, 2017 9:53 AM, "JamieHitGub" notifications@github.com wrote:

I cleared all cookies/history etc then removed app via the 'drag to bin' method on the mac. Manually checked for other files and removed them too. Still adverts only when logged in.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/4693#issuecomment-276729714, or mute the thread https://github.com/notifications/unsubscribe-auth/AIkDKCMdgh4KOdG_79-izZ8CygjJrbqRks5rYMaSgaJpZM4KUPn2 .

[pixelass]

@lukemulks I have no idea which "two ads setting pages" you are talking about.

[pixelass]

This one @lukemulks ?

Is it supposed to be ON or OFF ? Mine are all ON and I see ads when logged in

[srirambv]

@lukemulks Turning off the Signin ads and Signout Ads doesn't show ads now.

[pixelass]

All set to OFF

Now I have ads when not signed in too (bottom left ad box)

[lukemulks]

Apologies, should have been more clear.

That page is correct. Try switching to OFF for that switch.

There is a blue button that says "Control Signed in Ads" which will take you to a second page that includes an additional switch.

We basically want to try switching all to off, then clearing cache and cookies, signing back in and attempt to reproduce.

I have not been able to reproduce at all with these settings off, but have not considered that despite all the blocking measures in place, Google has penetrated authentication this deep to where this could be a potential factor.

[lukemulks]

@pixelass understood re: overlay, but what about actual video ads?

[pixelass]

I am not sure if that box in my last screenshot is considered an ad.

I could not reproduce pre-video ads after the change

[lukemulks]

@pixelass TY for confirming! I am going to file a separate issue to investigate the overlays, as those might fall under 1st-party, but good to hear regarding the preroll.

[pixelass]

Ad space not removed. I might have seen a ticket for this before, thought I'd mention it here. While the ad on the landingpage is not visible there is still the gap for it. (Reference from below: #344 thx @srirambv )

[lukemulks]

TY @pixelass will include that on the overlay issue that I'm going to file (and will double check existing ones). really appreciate the assistance!

[srirambv]

@pixelass @lukemulks This issue covers the cosmetic adblock https://github.com/brave/browser-laptop/issues/344

[pixelass]

@srirambv yes.. that's the one I meant, thx.

So I just clicked through 100 - 200 videos and reloaded about 20 of them ~10 times.

No video ads visible if the google ad settings (mentioned above) are turned OFF

[lukemulks]

Beautiful news. @pixelass what OS are you running?

[pixelass]

[JamieHitGub]

Still getting ad's with all this turned off, tried clearing browsing data and another re-install but still ad's. I'm using the same video for reference as it seems to proc an add every time, clicking other random videos still produces ad's with regularity, also on the most up to date osx release.

[lukemulks]

One note about the ad settings update within Google (the 3 switches). Google is a little opaque on when the changes to ad setttings take effect. This makes this a little tricky, because the boxes that pop up when you switch from ON to OFF mention that the changes may not take place immediately.

We're going to continue w/attempting to repro in MacOS, but so far for Windows it is looking like this has helped resolve, and from @pixelass feedback, is helping resolve to a degree in MacOS.

[echosa]

@lukemulks I don't understand what "two ads settings pages" or "3 switches" you're talking about. I went to the page that you linked: https://www.google.com/settings/u/0/ads/authenticated?hl=en

There's only one switch, and I turned it off:

I've visited a few video and haven't gotten pre-video ads yet. Seems promising, but I'll keep my eye out for more ads.

Can you tell me what page you're talking about with the three switches? I'd like to turn off as many advertising options as I can.

[lukemulks]

No problem @echosa

I've put together an image to help w/this, as Google has basically made this into a 2-page process (I'm writing a blog post covering these types of things that will be available to read soon that puts some more backstory to this).

• The image above includes both ad settings pages that I'm referring to.

• The switches are outlined in red in the image above. From the screencap that you've showed me, it appears that you've shut one off, which is great.

• If you scroll down further in the page, there is the blue button that I've outlined in yellow. Both pages include this. You'll want to click on that button, and it will take you to the second page.

• The second page has 2 additional switches, one for ads beyond Google, and one for Google Search Ads.

• You'll want to shut both of those switches off as well.

Those are the specific "ads settings" - none of which stop Google from collecting data, but change the data profile that they collect about you.

A couple of other things - for your privacy, which may help with this particular ads issue:

Google Activity Controls: https://myaccount.google.com/activitycontrols

I've been unable to reproduce ads in YT playback with the following settings disabled, which also should help control some of the data that you're knowingly (or more often, unknowingly) letting Google collect (note: they never really stop collecting user data, but that's a separate discussion that I'm writing about in a blog post).

I have the switches for these settings in the OFF position (gray, with the switch in the left position)

• Web & App Activity (paused)
• Location History (paused)
• Device Information (paused)
• Voice & Audio Activity (paused)

There are two Youtube specific settings at the bottom of that page, but I have them both ON (blue) and am not getting any ads. You can try shutting those off if you'd like. I have kept them on since I'm not seeing ads w/them on.

Just an FYI, before coming to work at Brave, I spent 5+ years in ad ops and ad products, a majority of which was spent working with Google on ad-related products.

In June 2016, Google updated their Privacy Policy to merge the user ad data with the user data profiles from their other products, and began to use non-ad URLs for ad-related delivery. This is why the issue at hand has been so difficult to resolve, because we have to take a strong but careful approach at blocking to ensure that we don't break core functionality that now has ad stuff merged in with it. Most people are unaware of this update.

Here's some info about the Google privacy policy update (which btw, went pretty much unreported by the press until Oct 2016).

http://www.slate.com/blogs/future_tense/2016/10/21/google_changed_a_major_privacy_policy_and_no_one_really_noticed.html

https://www.engadget.com/2016/10/21/googles-redefined-privacy-policy-lets-ads-follow-you-everywhere/

These types of changes by Google (+my personal desire for privacy protection) and the general deep-state surveillance complex that the ad industry has become is what led me to leave the ad world and come work at Brave on helping to protect privacy, and work on alternatives.

I know I put a lot in one comment here, but I hope it helps explain why this has been such a pain to get locked down.

[pixelass]

OFF TOPIC (sorry)

Just an FYI, before coming to work at Brave, I spent 5+ years in ad ops and ad products, a majority of which was spent working with Google on ad-related products.

@lukemulks "you monster" (good to have you here)

[lukemulks]

LOL @pixelass no worries (very happy to be here) ;-)

[echosa]

@lukemulks That screenshot will be helpful, but I still don't know how to get to those pages. Can you provide a link?

[cndouglas]

By the way, to generate a new Brave profile for testing but preserve your personal profile, just rename the Brave profile directory (at ~/Library/Application Support/brave) to something else (e.g., brave1). When you are done testing, delete the new directory (called brave) and rename the old one back to brave.

When I went to set up LastPass, it remembered my email address. I had told it to remember email, so normally that's expected, but having "completely" uninstalled, I would have expected that information to not be there.

@echosa: It is possible that LastPass has your email address stored in the macOS Keychain. You can find out by opening the Keychain Access utility.

[lukemulks]

@echosa no problem! Going to include them all here for quick reference:

Ads Settings: For these two settings, try this URL: https://www.google.com/settings/u/0/ads/anonymous?hl=en

• Ads based on your interests on websites beyond google.com
• Google Search Ads based on your interests

For the following setting, try this URL: https://www.google.com/settings/u/0/ads/authenticated?hl=en

• Ads based on your interests (When you are signed in to Google sites)

Related Privacy Settings: Google Activity Controls: https://myaccount.google.com/activitycontrols

I've been unable to reproduce ads in YT playback with the switches for these settings in the OFF position (gray, with the switch in the left position):

• Web & App Activity (paused)
• Location History (paused)
• Device Information (paused)
• Voice & Audio Activity (paused)

Note: There are two Youtube specific settings at the bottom of that page, but I have them both ON (blue) and am not getting any ads. You can try shutting those off if you'd like. I have kept them on since I'm not seeing ads w/them on.

Hope this helps!

[echosa]

Neither of those URLs take me to pages that look like your image. :-/ When logged in to Google, both of those first two links take me to the same page. The page they take me to is the last screenshot I posted a couple of comments back; the one with a single toggle, which I turned off.

If I visit the first link in a new session tab (which makes me not logged in), I get this:

I turned them off, but when I went back to the page in another new session tab, they were both on again. I guess I have to actually logout and turn those off, because a new session tab's changes aren't permanent or something? It's a bit confusing.

Either way, as you can see, I'm not seeing any pages as what your screenshot showed. Hopefully the pages I am seeing are equivalent, or at least good enough. I wonder why we see different things, though.

[pixelass]

@echosa @lukemulks what kind of Google accounts do you have? I have a free business account from the BETA-era of Google domains. Maybe it is different with default google accounts (foo@gmail.com vs. foo@bar.com)

[echosa]

I don't know how to answer that. I signed up for a Gmail account many, many years ago, when it was still invite-only. The rest, as they say, is history.

[pixelass]

I was actually right.

If you have a business account (use your own domain) you get the pages @lukemulks added as screenshots.

If you have a default gmail account example@gmail.com you get the screen that @echosa posted

screenshot from my test account

[echosa]

That makes sense for logged in, but what about logged out?

[lukemulks]

Thanks, these pages were accessed using consumer (free) user accounts, but will try from a business account too.

I apologize for the process being this way, Google is making this very difficult. I don't understand why Google couldn't just put them all on the same page, but I suspect the confusion is intentional given the amount of money they bring in from advertising.

I will try to see if I can reproduce a path with the settings that is a little easier.

What you could do, as an alternative, is attempt the URLs that I sent over from Chrome or another browser, which will apply to your Google account across any browser. Settings should stick (hopefully).

There might be some legacy account exceptions, but I also have had a Gmail account since the invite-only days.

On Feb 1, 2017 1:20 PM, "Gregor Adams" notifications@github.com wrote:

@echosa https://github.com/echosa @lukemulks https://github.com/lukemulks what kind of Google accounts do you have? I have a free business account from the BETA-era of Google domains. Maybe it is different with default google accounts (foo@gmail.com vs. foo@bar.com)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/4693#issuecomment-276785772, or mute the thread https://github.com/notifications/unsubscribe-auth/AIkDKFHjZTezBpE99BTwt9nnjEu8W3IXks5rYPcdgaJpZM4KUPn2 .

[pixelass]

The link is on the page that business accounts get.

[pixelass]

Maybe it's a feature that has not been ported to either of the two versions. They might not even use the same logic, framework, whatever. Google is big at making a lot of custom stuff that doesn't fit together, it's part of moving along and building new ideas. Just spitballing here though.

EDIT: There are a lot of domain speciffic settings available. You can add and remove different apps to your domain, so the settings page might also take that into account. Just looking at the description of what will or will not be personalized if the switch is toggled.

[echosa]

Well, I turned off what I could find, so hopefully that'll do some good. Sticking to the original plan: ads seem to not be playing, which is great, but I'll keep an eye out and report any that do. Thanks for this Google settings tangent. :+1:

I don't understand why Google couldn't just put them all on the same page

If it is easy to do so, more people will turn off the tracking and ads and such. Google doesn't want that but also wants to be able to say they provide a way to do so. So they provide a complicated way people are likely to avoid or miss. It's a win/win for them. :-P

[pixelass]

@lukemulks that confused me. Do you have a custom domain? Those were given in the invite and beta phase for free too. My test account (@gmail.com) is about 1 year old and it has is a vanilla gmail account and I get the same screen as @echosa

My own account (@pixelass.com) has the same screen as you posted

[lukemulks]

No custom domain in my case.

At this point, I'd just suggest turning off the settings discussed in whichever form they are presented, close the browser when completed, relaunch, clear cache and cookies, sign in and attempt to check YouTube for ad playback.

That should hopefully result in resolving the ads issue.

Thanks again for the persistence and assistance. :-)

On Feb 1, 2017 1:45 PM, "Gregor Adams" notifications@github.com wrote:

@lukemulks https://github.com/lukemulks that confused me. Do you have a custom domain? Those were given in the invite and beta phase for free too. My test account is about 1 year old and it has is a vanilla gmail account and I get the same screen as @echosa https://github.com/echosa

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brave/browser-laptop/issues/4693#issuecomment-276792710, or mute the thread https://github.com/notifications/unsubscribe-auth/AIkDKExhSRVwgE36Q1O6vi0YB5GXjEHyks5rYP0LgaJpZM4KUPn2 .

[lukemulks]

With the latest set of settings adjustments (Google ads settings), and the attempts to repro by @srirambv @pixelass, @echosa and me that results in no ads displaying, and the lack of additional reports from users post v0.13.1, I'm going to close out the issue at this time.

If there are repeats of ads displaying for users that are signed in, please let us know and we'll triage those cases into a new issue to specifically investigate further. Thanks again to everyone that helped get us to this point.

[tcr]

For future travelers: following the instructions in this comment by @lukemulks resolved the issue for me in Brave 0.13.0.

[borntohonk]

I've had those google settings off forever @lukemulks

looking in the debugger / developer tools, it's apparent that google forces another video up instead of the video I intend to watch.

note: I have a pi-hole on my network aswell, which has successfully prevented any loading of ads in any browser on any device (including my ipad) until recently, probally february first. So this is a youtube thing. (https://github.com/pi-hole/pi-hole)

A friend links me this:

https://www.youtube.com/watch?v=ye24Qehidkg

and this gets forced before it (as an ad)

https://www.youtube.com/watch?v=Lpbda_NXRL0

"html5-video-player ad-created ad-showing ad-interrupting videoAdUiRedesign ytp-video-ad-learn-more-ui ytp-title-extra-info paused-mode"

I'm guessing this is a testpilot system being rolled out, and that it's being regionally tested.

Might be interesting to note, the videos that get forced as ads, don't have any ads themselves.

mashing F5 on any other video gives ads 100% of the time before loading the intended video I'm clicking (randomly).

but doing the same on the videos designated as ads, it jumps straight to the video. (probally some sort of whitelist to not get an ad ontop of a forced ad?)

here's a recording demonstrating it, brave adblocker enabled, pihole also active on a random video I got to by just clicking random trending videos.

https://a.pomf.cat/vqaxlm.webm

just for referance, there are ads on youtube that my pihole do prevent addition to the ones violating my eyes.