search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

"login with google" doesn't log you in #57

Closed bridiver closed 8 years ago

bridiver commented 8 years ago

Login to Feedly.com using google never actually logs me in. I can access mail.google.com after the authentication through the feedly sign-on page, but I can't access Feedly itself. I haven't tried other sites that use google login

bbondy commented 8 years ago

we're probably adblocking too much, there's a fix I need to do there about properly detecting third party hosts. Don't spend time investigating this since it's probably related.

bridiver commented 8 years ago

I didn't see anything being blocked

bbondy commented 8 years ago

pls try with updating package.json with the stock electron-prebuilt to see if it works.

diracdeltas commented 8 years ago

I noticed this yesterday on asana.com too

bbondy commented 8 years ago

ya after seeing the problem I don't think it's related to adblock.

diracdeltas commented 8 years ago

confirmed that it doesn't work with stock electron-prebuilt either

login with facebook on spotify.com works though

bbondy commented 8 years ago

thanks for verifying

bridiver commented 8 years ago

it looks like the problem is window.opener. There are some hints on how we might work around it here: https://github.com/atom/electron/issues/1865