search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Missing l10n strings - Korean #6308

Closed alexwykoff closed 6 years ago

alexwykoff commented 7 years ago

Did you search for similar issues before submitting this one? Yes Describe the issue you encountered: In the latest build of 0.13.0, a significant number of missing translations were discovered for the Korean language.

Expected behavior: Each language should be in parity for coverage.

alexwykoff commented 7 years ago

Found a few more :

screen shot 2016-12-19 at 8 47 16 pm screen shot 2016-12-19 at 8 48 24 pm screen shot 2016-12-19 at 8 48 24 pm screen shot 2016-12-19 at 8 48 36 pm screen shot 2016-12-19 at 8 48 48 pm screen shot 2016-12-19 at 8 49 06 pm screen shot 2016-12-19 at 8 49 13 pm screen shot 2016-12-19 at 8 49 55 pm screen shot 2016-12-19 at 8 50 02 pm
luixxiul commented 7 years ago

I thought @bradleyrichter has asked us somewhere not to make "Brave Payments" be localizable.

Also I'm not sure how much about:styles should be localizable because the official language here is English and development work is done in English too. I think we could disable its localization for now. I simply don't think it is worth for volunteer translatiors at Transifex taking time to localize them until this project gets more international developers.

alexwykoff commented 7 years ago

I would then ask that the Japanese translation be backed out.

screen shot 2016-12-20 at 11 58 23 am
bradleyrichter commented 7 years ago

Correct. "Brave Payments" should not be translated.

luixxiul commented 7 years ago

@alexwykoff I agree with you if I'm honest. I localized it, being not sure if it's worth translating white button into 白ボタン since we don't do like this way: <button className='白ボタン'>.

bbondy commented 7 years ago

We should only track issues with not marked up strings and missing localization strings should be handled in transifex. Is this needed to be left open?

alexwykoff commented 7 years ago

I would argue that our l10n issues need to remain open if there are no other issues to track l10n coverage for 1.0. This is easy polish which means a lot to users in each of the regions represented.

bbondy commented 7 years ago

Quality of localized builds is an issue but our developers cannot fix them, it's done by our localizers that have accounts on transifex and not here. No task by our developers can fix localized strings if the issue is a missing translation. It needs to be done in the people in that system, not this system.

Transifex also has a little progress bar that tells you how much each language is translated. We should put in another order there if we have missing strings. @aekeus should do it.

Please do open issues if we have strings that cannot be localized by that system here, but if something can be managed there then we should jus pay to get them up to date.

bbondy commented 7 years ago

@aekeus sorry I didn't mean that to sound like I was saying you "should have" done it, but just that I'd like you to do it, and I talked to @alexwykoff via DM and we'll add an asana task as a reminder of that. 👍

luixxiul commented 7 years ago

Please do open issues if we have strings that cannot be localized by that system

I'd like to see https://github.com/brave/browser-laptop/issues/5733 and https://github.com/brave/browser-laptop/issues/4102 fixed. If it is possible to set the URL anchor links as varibles, that would be perfect.

aekeus commented 7 years ago

@bbondy I will issue new translation requests to complete the languages we have identified as 100% completed for 1.0 release.