search

brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 975 forks source link

Windows x64 spot check 0.13.0 preview 7 #6479

Closed srirambv closed 7 years ago

srirambv commented 7 years ago

Installer

  1. [x] Check that installer is close to the size of last release.
  2. [x] Check signature: If OS Run spctl --assess --verbose /Applications/Brave.app/ and make sure it returns accepted. If Windows right click on the installer exe and go to Properties, go to the Digital Signatures tab and double click on the signature. Make sure it says "The digital signature is OK" in the popup window.
  3. [x] Check Brave, electron, and libchromiumcontent version in About and make sure it is EXACTLY as expected.

Per release specialty tests

  1. [ ] Test each item in release notes for the release that's going out.

Ledger

  1. [ ] Create a wallet with a value other than $5 selected in the monthly budget dropdown. Click on the 'Add Funds' button and check that Coinbase transactions are blocked.
  2. [x] Remove all ledger-*.json files from ~/Library/Application\ Support/Brave/. Go to the Payments tab in about:preferences, enable payments, click on create wallet. Check that the add funds button appears after a wallet is created.
  3. [ ] Click on add funds and verify that adding funds through Coinbase increases the account balance.
  4. [ ] Repeat the step above but add funds by scanning the QR code in a mobile bitcoin app instead of through Coinbase.
  5. [x] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table.
  6. [x] Go to https://jsfiddle.net/LnwtLckc/5/ and click the register button. In the Payments tab, click add funds. Verify that the transfer funds button is visible and that clicking on transfer funds opens a jsfiddle URL in a new tab.
  7. [x] Go to https://jsfiddle.net/LnwtLckc/5/ and click unregister. Verify that the transfer funds button no longer appears in the add funds modal.
  8. [x] Check that disabling payments and enabling them again does not lose state.

Data

  1. [x] Make sure that data from the last version appears in the new version OK.
  2. [x] Test that the previous version's cookies are preserved in the next version.

About pages

  1. [x] Test that about:adblock loads
  2. [x] Test that about:autofill loads
  3. [x] Test that about:bookmarks loads bookmarks
  4. [x] Test that about:downloads loads downloads
  5. [x] Test that about:extensions loads
  6. [x] Test that about:history loads history
  7. [x] Test that about:passwords loads
  8. [x] Test that about:styles loads
  9. [x] Test that about:preferences changing a preference takes effect right away
  10. [x] Test that about:preferences language change takes effect on re-start
  11. [x] Test that about.com without the http protocol is loaded from URL bar

Bookmarks

  1. [x] Test that creating a bookmark on the bookmarks toolbar works
  2. [x] Test that creating a bookmark folder on the bookmarks toolbar works
  3. [x] Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
  4. [x] Test that clicking a bookmark in the toolbar loads the bookmark.
  5. [x] Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.

Context menus

  1. [x] Make sure context menu items in the URL bar work
  2. [x] Make sure context menu items on content work with no selected text.
  3. [x] Make sure context menu items on content work with selected text.
  4. [x] Make sure context menu items on content work inside an editable control (input, textarea, or contenteditable).

Find on page

  1. [x] Ensure search box is shown with shortcut
  2. [x] Test successful find
  3. [x] Test forward and backward find navigation
  4. [x] Test failed find shows 0 results
  5. [x] Test match case find

Geolocation

  1. [x] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works

Site hacks

  1. [x] Test https://www.twitch.tv/adobe sub-page loads a video and you can play it

Downloads

  1. [x] Test downloading a file works and that all actions on the download item works.

Fullscreen

  1. [x] Test that entering full screen window works View -> Toggle Full Screen. And exit back (Not Esc).
  2. [x] Test that entering HTML5 full screen works. And Esc to go back. (youtube.com)

Tabs and Pinning

  1. [x] Test that tabs are pinnable
  2. [x] Test that tabs are unpinnable
  3. [x] Test that tabs are draggable to same tabset
  4. [x] Test that tabs are draggable to alternate tabset

Zoom

  1. [x] Test zoom in / out shortcut works
  2. [x] Test hamburger menu zooms.
  3. [x] Test zoom saved when you close the browser and restore on a single site.
  4. [x] Test zoom saved when you navigate within a single origin site.
  5. [x] Test that navigating to a different origin resets the zoom

Bravery settings

  1. [x] Check that HTTPS Everywhere works by loading http://www.apple.com
  2. [x] Turning HTTPS Everywhere off and shields off both disable the redirect to https://www.apple.com
  3. [x] Check that ad replacement works on http://slashdot.org
  4. [x] Check that toggling to blocking and allow ads works as expected.
  5. [x] Test that clicking through a cert error in https://badssl.com/ works.
  6. [x] Test that Safe Browsing works (http://downloadme.org/)
  7. [x] Turning Safe Browsing off and shields off both disable safe browsing for http://downloadme.org/.
  8. [x] Visit https://brianbondy.com/ and then turn on script blocking, nothing should load. Allow it from the script blocking UI in the URL bar and it should work.
  9. [x] Test that about:preferences default Bravery settings take effect on pages with no site settings.
  10. [x] Test that turning on fingerprinting protection in about:preferences shows 3 fingerprints blocked at https://jsfiddle.net/bkf50r8v/13/. Test that turning it off in the Bravery menu shows 0 fingerprints blocked.
  11. [x] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked.
  12. [x] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on.

Content tests

  1. [x] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Test that context menus work in the new twitter tab.
  2. [x] Load twitter and click on a tweet so the popup div shows. Click to dismiss and repeat with another div. Make sure it shows.
  3. [x] Go to http://www.bennish.net/web-notifications.html and test that clicking on 'Show' pops up a notification asking for permission. Make sure that clicking 'Deny' leads to no notifications being shown.
  4. [x] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password shows up in about:passwords. Then reload https://trac.torproject.org/projects/tor/login and make sure the password is autofilled.
  5. [ ] Open a github issue and type some misspellings, make sure they are underlined.
  6. [ ] Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text.
  7. [x] Make sure that Command + Click (Control + Click on Windows, Control + Click on Ubuntu) on a link opens a new tab but does NOT switch to it. Click on it and make sure it is already loaded.
  8. [x] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works.
  9. [x] Test that PDF is loaded at http://www.orimi.com/pdf-test.pdf
  10. [x] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run).

Flash tests

  1. [ ] Turn on Flash in about:preferences#security. Test that clicking on 'Install Flash' banner on myspace.com shows a notification to allow Flash and that the banner disappears when 'Allow' is clicked.
  2. [x] Test that flash placeholder appears on http://www.y8.com/games/superfighters

Autofill tests

  1. [x] Test that autofill works on http://www.roboform.com/filling-test-all-fields

Session storage

Do not forget to make a backup of your entire ~/Library/Application\ Support/Brave folder.

  1. [x] Temporarily move away your ~/Library/Application\ Support/Brave/session-store-1 and test that clean session storage works. (%appdata%\Brave in Windows, ./config/brave in Ubuntu)
  2. [x] Test that windows and tabs restore when closed, including active tab.
  3. [x] Move away your entire ~/Library/Application\ Support/Brave folder (%appdata%\Brave in Windows, ./config/brave in Ubuntu)

Cookie and Cache

  1. [x] Make a backup of your profile, turn on all clearing in preferences and shut down. Make sure when you bring the browser back up everything is gone that is specified.
  2. [x] Go to http://samy.pl/evercookie/ and set an evercookie. Check that going to prefs, clearing site data and cache, and going back to the Evercookie site does not remember the old evercookie value.

Update tests

  1. [x] Test that updating using BRAVE_UPDATE_VERSION=0.8.3 env variable works correctly.
willy-b commented 7 years ago

since @bbondy's awesome fix for webview.printToPDF is in this version can you also check the payment history PDF on Windows as part of this?

srirambv commented 7 years ago

Flash not loading on myspace.com, opens adobe website Spell check not working Ctrl+Mouse Wheel up/Down doesn't zoom in/out (#6482) @willy-b Still the same issue as I posted on #6385

bbondy commented 7 years ago

For #6385 should be working in next preview.

bbondy commented 7 years ago

Is there a bug for spell check not working? If not please post asap for 0.13.

bbondy commented 7 years ago

I posted for it here: https://github.com/brave/browser-laptop/issues/6507

Just wanted to ask though to make sure to always post a bug because it can very easily be lost and forgotten about especially since this one wasn't tagged with 0.13 either. Thanks!

bbondy commented 7 years ago

Mouse wheel is working now in next preview as well.