brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 974 forks source link

Be able to drop webloc files #6847

Open bbondy opened 7 years ago

bbondy commented 7 years ago

Posting for a friend: You should be able to drop in .webloc files into the about:newtab window. Dropping .webloc files into about:blank or other pages that are already loaded works without any issues, but it would be nice if you could just launch Brave and drop the file into about:newtab right away.

The other issue with .webloc files is that when you attempt to drop them into the tab bar, you'll either open the XML file and get the following:

"This XML file does not appear to have any style information associated with it. The document tree is shown below."

Or you'll search for that specific file in your default search engine rather than parsing the .webloc file and loading the page correctly.

kevinlawler commented 7 years ago

Further: Dropping an existing webloc onto the bookmark bar gives odd results. Expected: a comparable bookmark is created. Actual: The literal, raw XML content of the webloc is displayed (like an unresolved symlink). I've also seen it result in a web search (probably something missing), but I can't reproduce that at the moment (even by destroying the XML file the bookmark points to).

See also #3164