brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.94k stars 975 forks source link

cnn.com - Investigate: reports of lower block counts from Community #8637

Closed lukemulks closed 6 years ago

lukemulks commented 7 years ago

Issue: Report from Brave Community that CNN.com has lower block counts than it has previously had, and that uBO/ABP have higher counts than Brave currently has (though, I can confirm that these counts were aligning within the past 12 days).

Community Post: https://community.brave.com/t/shields-comparison-test/2610

Contributor Brave profile:

Brave: 0.15.1 
rev: ea5024d1f3e47d34de79b70e3cd74f1408c985ce 
Muon: 2.58.8 
libchromiumcontent: 58.0.3029.81 
V8: 5.8.283.32 
Node.js: 7.9.0 
Update Channel: dev 
os.platform: linux 
os.release: 4.4.0-66-generic 
os.arch: x64

Community contributor issue description

I noticed after installing that the shields don't work as they used to be on previous ver.

For example i tryed http://edition.cnn.com/ on Brave and shields reported 14 threats in total with settings of block ads , HTTPS on , Fingerprinting protection , block phishing, block 3d party cockies .

While trying the same page on a other browser with HTTPS everywhere on , adblock on and privacy bagger on the total threats blocked are 27.

Its the first time that happens since i first installed brave.

lukemulks commented 7 years ago

Ran an initial check against uBO.

Confirming that there's a regression.

We were blocking ~27 as of ~12 days ago. Now, consistently ~12-14 count.

uBO is blocking 20+

Majority of requests that are being filtered are filtered by EasyPrivacy.

Could be a shift in filter list priorities, due to EasyList being a mess of exceptions lately.

Going to investigate ABP & AB to confirm.

Will likely push for EasyPrivacy addition if hypothesis turns out to be correct.

Request comparison: Brave, ads blocked, FP enabled, 3p cookie control

http://native.sharethrough.com/assets/sfp-creative-hub-listener.js
http://ads.rubiconproject.com/header/11078.js
http://ad.doubleclick.net/ddm/ad/mahxqqsz/pwfneuy/;ord=1493787679336?
http://ad.doubleclick.net/ddm/ad/hksmprucua/novezw/;ord=1493787679338?
http://aax.amazon-adsystem.com/e/dtb/bid?src=3159&u=http%3A%2F%2Fwww.cnn.com%2F&cb=4230246&t=1000
http://rtax.criteo.com/delivery/rta/rta.js?netId=4157&cookieName=crtg_trnr&rnd=71513616171&varName=crtg_content
http://static.chartbeat.com/js/chartbeat_mab.js
http://amplifypixel.outbrain.com/pixel?mid=006eb1f8dded486e0974a6b4a7b9805f5f
http://cdn.krxd.net/controltag?confid=ITb_4eqO
http://widgets.outbrain.com/outbrain.js
http://secure-us.imrworldwide.com/cgi-bin/m?ci=us-204044h&cg=0&cc=1&si=http%3A//www.cnn.com/&rp=http%3A//www.cnn.com&ts=compact&rnd=1493787679020
http://b.scorecardresearch.com/r?c2=6035748&d.c=gif&d.o=cnn-adbp-domestic&d.x=223104514&d.t=page&d.u=http%3A%2F%2Fwww.cnn.com%2F
http://static.chartbeat.com/js/chartbeat.js

uBO

||criteo.com^
||facebook.com*/impression.php
||amazon-adsystem.com^
/bcn?
||doubleclick.net^
||chartbeat.com^
||metrics.cnn.com^
||imrworldwide.com^
@@||fastly.net/ad/$image
@@||fastly.net/ad/$script
||outbrain.com^
||usabilla.com^$third-party
||bat.bing.com^
||googletagservices.com/tag/js/gpt.js$script
||krxd.net^$third-party
||ugdturner.com^$third-party
||sharethrough.com^$third-party
||optimizely.com^$third-party
lukemulks commented 7 years ago

Also, this was a surprise to see (and is blocked by EasyPrivacy)

Primary request:

http://bat.bing.com/bat.js

Associated tracking:

Request URL:https://bat.bing.com/action/0?ti=5526986&Ver=2&mid=10444972-1a0d-eb36-4e74-d0d45e0823c2&evt=pageLoad&sid=7b064ac7-0&lt=1357&pi=0&lg=en-US&sw=2195&sh=1235&sc=24&r=http%3A%2F%2Fwww.cnn.com&tl=CNN%20-%20Breaking%20News,%20Latest%20News%20and%20Videos&kw=cnn%20news,%20daily%20news,%20breaking%20news,%20news%20today,%20current%20events&p=http%3A%2F%2Fwww.cnn.com%2F%3Frefresh%3D1&rn=126730