brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.94k stars 974 forks source link

opening URL from external application (Thunderbird/LibreOffice) does not work any more #9193

Closed crysman closed 7 years ago

crysman commented 7 years ago

Xubuntu 16.10 Brave 0.15.310 rev 6b5e4e2 os.platform linux os.release 4.8.0-53-generic os.arch x64

stefonarch commented 5 years ago

Hm, strange that the script doesn't work for you. I've switched to the chrome version and with it this issue isn't present anymore.

MarshCastle commented 5 years ago

has this got to do with my setup only accepting the argument / url as a quoted / escaped string? i.e. I get:

$ brave-browser https://www.google.com/search?ei=UQz0W-CeLIyUgAbKmac4&q=hello+chicken&oq=hello+chicken&gs_l=psy-ab.3..0l10.14437.17340..18005...0.0..0.59.412.8......0....1..gws-wiz.......0i71j0i67j0i131j0i3.4ogVGROI0jk

fails at the first '&', whereas using quotes:

$ brave-browser "https://www.google.com/search?ei=UQz0W-CeLIyUgAbKmac4&q=hello+chicken&oq=hello+chicken&gs_l=psy-ab.3..0l10.14437.17340..18005...0.0..0.59.412.8......0....1..gws-wiz.......0i71j0i67j0i131j0i3.4ogVGROI0jk"

it works without any problem.

I can't seem to push quotes through from a script though. quotes get stripped and I end up in scenario 1, and if i use \" to escape them then it pushes it straight to the browser and I get a complete faiulre to load a page.

is there a way to feed a quoted string from a script?

MarshCastle commented 5 years ago

ps: (sorry) I did try to adapt the Chrome .desktop file, but had no joy :(

Cheers :D