Serve OS Specific Components

brave / go-update

Component update server for brave-core written in Go

Mozilla Public License 2.0

28 stars 23 forks source link

Serve OS Specific Components #57

Open jsecretan opened 3 years ago

jsecretan commented 3 years ago

A component ID should have the option of being distributed in an OS specific way. This is motivated by a desire to make OS specific NTP-SI packages for each platform, so that the images can be optimized for mobile, or reflect differences in the platforms (e.g. rewards is not available on iOS and any house campaign should reflect that).

bbondy commented 3 years ago

Not opposed but just wanted to share a couple of work arounds that we have currently:

If it's not a lot of data, just include different files in the component, 1 per platform. Or a JSON file can for example have a per platform key.
Can use different component IDs per platform

jsecretan commented 3 years ago

Thanks @bbondy fair point and I think @petemill has convinced me that different component ids per platform is probably cleaner. We're having a kick off first thing next week and I'll keep this open until then. If we go a different direction I'll close this out.