brave / ledger-publisher

Deprecated, please see
https://github.com/brave-intl/bat-publisher
Mozilla Public License 2.0
8 stars 12 forks source link

minor improvements #13

Closed mrose17 closed 8 years ago

mrose17 commented 8 years ago
  1. if there is an error in require('./categories').all(), invoke the callback with null
  2. figure out an easy way to generate var rules in index.js, perhaps by having it do a require(...) on a file that is generated on commit
aekeus commented 8 years ago

The callback currently takes two parameters, the first is the err object and the second is the array of rules. Would you like the array of rules parameter to be null when an error occurs?

mrose17 commented 8 years ago

i thought there was only one parameter. in that case: when an error occurs, please use (err, null) thanks!