search

brave / leo

Design tokens for the Brave's design system known as Leo
https://nala.bravesoftware.com/
Mozilla Public License 2.0
45 stars 24 forks source link

All font variables in css should specify a fallback #482

Open petemill opened 11 months ago

petemill commented 11 months ago

Fallback should at least be sans-serif

AlanBreck commented 11 months ago

@aguscruiz, can you define fallback fonts in Figma which can be included in the export?

aguscruiz commented 11 months ago

@aguscruiz, can you define fallback fonts in Figma which can be included in the export?

No, sadly I can't define that in Figma. But if it helps, we could use this https://systemfontstack.com/

AlanBreck commented 11 months ago

My larger concern is that since it's not configurable in Figma, and therefore included in the export, we'll have to hard code that the fallback is sans-serif, so if we ever introduced serif (like with Fletcha for marketing), we'd have to hardcode a mapping for the fonts to their fallbacks.

Not a big deal, especially given the limited number of fonts we use. Just not ideal.