search

brave / link-bubble

Brave Link Bubble Browser
https://www.brave.com
1.01k stars 183 forks source link

Chrome Custom Tabs #731

Open Nemisor opened 8 years ago

Nemisor commented 8 years ago

Just a suggestion, but it seems that several of the outstanding issues might be solved by switching to chrome custom tabs. For instance, Flyperlink allows selecting either webview or custom tabs, and the custom tabs option seems to be superior in many ways. Copy/paste test works normally, much faster rendering speeds, etc. The only question is how difficult would it be (or if even possible) to include the current Brave shields using this different engine. Any thoughts on this, or am I just indulging in theorycraft?

bbondy commented 8 years ago

I think you can't add network filtering nor the Brave shields using CCT. We could add an option for users to use this method instead but it's probably a bit lower priority since we can't add our value ads on top.

Nemisor commented 8 years ago

That's unfortunate, but makes sense. Flyperlink has that option, and cannot block ads or anything while using it, so it ends up being just like Chromer without any bonuses. Any thought on using the Mozilla engine? Since it certainly allows modification and plugins.

bbondy commented 8 years ago

We're working on getting the webview into an activity now, it's getting close. This will fix the copy / paste and various other things. I think the perf would actually be better due to the shields for the webview vs Chrome.

Nemisor commented 8 years ago

Well then, I'll be looking forward to that. Will it also permit consistent downloading? Several sites (apkmirror.com for one) simply launch the fallback browser when attempting to download...