search

brave / link-bubble

Brave Link Bubble Browser
https://www.brave.com
1.01k stars 183 forks source link

support substring match for Domain redirects. e.g: .doorkeeper.com #843

Closed sanpei3 closed 8 years ago

sanpei3 commented 8 years ago

I requested below function to brave on April/15/2016. And issue is https://github.com/brave/browser-android/issues/749.

Finally I created patch and currently I use self-compiled brave on my Nexus 5(Android6.0) without issue. I hope to accept this changes.

Yours.

I bought Link Bubble for Android and currently use Brave for Android. This application is very useful and I like it.

But some reasons, I added "Domain redirects". Unfortunately currently "Domain redirects" is not support regular expression or sub string match.

For example, there are many URLs for same domain("doorkeeper.jp") https://jazug.doorkeeper.jp/ https://nishinipporirb.doorkeeper.jp/ ....

If I want to "Domain redirects" above urls, I need to set all hostnames. So do you have any support plan about regular expression or sub string match?

SergeyZhukovsky commented 8 years ago

Thanks for doing that. I'm not sure we need regular expression here, the substring match you did is enough.