search

brave / link-bubble

Brave Link Bubble Browser
https://www.brave.com
1.01k stars 183 forks source link

HTTPS Everywhere build-in not functioning correctly #851

Open Hainish opened 8 years ago

Hainish commented 8 years ago

cc @diracdeltas

Our long-time reference URL for testing purposes is http://libssh.org/, expecting a redirect to https://libssh.org/

Downloading the browser, installing it and navigating to that URL does not result in the expected behavior.

SergeyZhukovsky commented 8 years ago

It is just need to be updated to the latest rules set. It works properly on chromium based browser. I'll do it for the next release.

Hainish commented 8 years ago

Which ruleset version is it currently using? This rule has been active since Feb 28, 2014.

SergeyZhukovsky commented 8 years ago

It is 5.1.2.

Hainish commented 8 years ago

Release 5.1.2 was made in December, 2015, so libssh.org should definitely redirect using those rulesets. Please check your implementation of the ruleset redirection code - this should be working.

diracdeltas commented 8 years ago

confirmed libssh is redirecting on brave-laptop so it should work on android

@Hainish is apple.com redirecting to https for you?

Hainish commented 8 years ago

@diracdeltas no, apple.com is not

SergeyZhukovsky commented 8 years ago

@Hainish you have to enable HTTPSE in Settings->More... It is off by default on Android. But in any case libssh.org doesn't redirect, I'll check that on next release.

diracdeltas commented 8 years ago

verified that libssh.org redirects correctly on iOS brave. cc @garvankeeley